[3929][4742][ADD] restful #117
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AungKoKoLin1997
force-pushed
the
15.0-add-restful
branch
from
06e7f31
to
07ac8b5
Compare
AungKoKoLin1997
force-pushed
the
15.0-add-restful
branch
from
a134d65
to
3d5a270
Compare
yostashiro
reviewed
Jul 25, 2024
| @@ -154,7 +154,7 @@ def post(self, model=None, id=None, **payload): | |||
| request.env.cr.rollback() | |||
| return invalid_response("params", e) | |||
| else: | |||
| data = resource.read(fields=fields) | |||
| data = {"id": resource.id} | |||
There was a problem hiding this comment.
For this particular case, I do not feel very comfortable with simply overriding the code. Can we instead comment out the original line, and state the reason of the change, marking it as our local fix.
yostashiro
requested changes
Jul 29, 2024
There was a problem hiding this comment.
@AungKoKoLin1997 Please organize the commits, with the first commit untouched from the original code, assigning proper commit messages.
This commit improves the code for handling the x-www-form-urlencoded content-type and passing parameters in the correct format. Before this commit, when calling an API with x-www-form-urlencoded and passing parameters, the fields could not adapt well if there were relational fields with record-related fields (e.g., many2one) because the parameters were passed as strings.
AungKoKoLin1997
force-pushed
the
15.0-add-restful
branch
from
c1060a9
to
463ecdc
Compare
yostashiro
approved these changes
Aug 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
3929
4742