Skip to content

Commit

Permalink
Rewrite include_once as require_once
Browse files Browse the repository at this point in the history
Every included file is actually required.
Define require_once without parenthesis as it is a language
construct, not a PHP function.
Use __DIR__ instead of indirect dirname(__FILE__) in modules.
  • Loading branch information
herrvigg committed Mar 13, 2023
1 parent 8d816e0 commit a41ff8a
Show file tree
Hide file tree
Showing 3 changed files with 5 additions and 5 deletions.
2 changes: 1 addition & 1 deletion modules/qtx_module_loader.php
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@ public static function load_active_modules() {

foreach ( $modules_state as $module_id => $state ) {
if ( $state === QTX_MODULE_STATE_ACTIVE ) {
include_once( QTRANSLATE_DIR . '/modules/' . $module_id . '/' . $module_id . '.php' );
require_once QTRANSLATE_DIR . '/modules/' . $module_id . '/' . $module_id . '.php';
}
}
}
Expand Down
2 changes: 1 addition & 1 deletion modules/slugs/admin/slugs-admin.php
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
if ( ! defined( 'ABSPATH' ) ) {
exit;
}
include_once( dirname( __FILE__ ) . '/slugs-settings.php' );
require_once __DIR__ . '/slugs-settings.php';

// add filters
add_filter( 'wp_get_object_terms', 'qtranxf_slugs_get_object_terms', 0, 4 );
Expand Down
6 changes: 3 additions & 3 deletions modules/slugs/slugs.php
Original file line number Diff line number Diff line change
@@ -1,11 +1,11 @@
<?php
const QTX_SLUGS_META_PREFIX = 'qtranslate_slug_'; // The language code is appended.

include_once( dirname( __FILE__ ) . '/qtx_module_slugs.php' );
include_once( dirname( __FILE__ ) . '/src/slugs-utils.php' );
require_once __DIR__ . '/qtx_module_slugs.php';
require_once __DIR__ . '/src/slugs-utils.php';

if ( is_admin() ) {
include_once( dirname( __FILE__ ) . '/admin/slugs-admin.php' );
require_once __DIR__ . '/admin/slugs-admin.php';
}

add_filter( 'qtranslate_convert_url', 'qtranxf_slugs_convert_url', 10, 2 );
Expand Down

0 comments on commit a41ff8a

Please sign in to comment.