Skip to content

FROMGIT: arm64: dts: qcom: lemans: add QCrypto node#179

Merged
sgaud-quic merged 1 commit intoqualcomm-linux:qcom-6.18.yfrom
arakshit011:lemans-qcrypto
Feb 4, 2026
Merged

FROMGIT: arm64: dts: qcom: lemans: add QCrypto node#179
sgaud-quic merged 1 commit intoqualcomm-linux:qcom-6.18.yfrom
arakshit011:lemans-qcrypto

Conversation

@arakshit011
Copy link

@arakshit011 arakshit011 commented Jan 19, 2026

Add Qualcomm Crypto Engine device node for LeMans platform.

QCE and Crypto DMA nodes patch was applied as part of the commit 7ff3da4 ("arm64: dts: qcom: sa8775p: add QCrypto nodes"), however was partially reverted by commit 92979f1 ("arm64: dts: qcom: sa8775p: Partially revert "arm64: dts: qcom: sa8775p: add QCrypto nodes"") due to compatible-string being miss-matched against schema.

Reviewed-by: Dmitry Baryshkov dmitry.baryshkov@oss.qualcomm.com
Link: https://lore.kernel.org/all/20251224-enable-qualcomm-crypto-engine-for-lemans-v2-1-a707e3d38765@oss.qualcomm.com/
CRs-Fixed: 4409166

sgaud-quic pushed a commit to qualcomm-linux-stg/kernel that referenced this pull request Jan 20, 2026
@LeviYeoReum
smc91x: fix broken irq-context in PREEMPT_RT
6402078 
When smc91x.c is built with PREEMPT_RT, the following splat occurs
in FVP_RevC:

[   13.055000] smc91x LNRO0003:00 eth0: link up, 10Mbps, half-duplex, lpa 0x0000
[   13.062137] BUG: workqueue leaked atomic, lock or RCU: kworker/2:1[106]
[   13.062137]      preempt=0x00000000 lock=0->0 RCU=0->1 workfn=mld_ifc_work
[   13.062266] C
** replaying previous printk message **
[   13.062266] CPU: 2 UID: 0 PID: 106 Comm: kworker/2:1 Not tainted 6.18.0-dirty qualcomm-linux#179 PREEMPT_{RT,(full)}
[   13.062353] Hardware name:  , BIOS
[   13.062382] Workqueue: mld mld_ifc_work
[   13.062469] Call trace:
[   13.062494]  show_stack+0x24/0x40 (C)
[   13.062602]  __dump_stack+0x28/0x48
[   13.062710]  dump_stack_lvl+0x7c/0xb0
[   13.062818]  dump_stack+0x18/0x34
[   13.062926]  process_scheduled_works+0x294/0x450
[   13.063043]  worker_thread+0x260/0x3d8
[   13.063124]  kthread+0x1c4/0x228
[   13.063235]  ret_from_fork+0x10/0x20

This happens because smc_special_trylock() disables IRQs even on PREEMPT_RT,
but smc_special_unlock() does not restore IRQs on PREEMPT_RT.
The reason is that smc_special_unlock() calls spin_unlock_irqrestore(),
and rcu_read_unlock_bh() in __dev_queue_xmit() cannot invoke
rcu_read_unlock() through __local_bh_enable_ip() when current->softirq_disable_cnt becomes zero.

To address this issue, replace smc_special_trylock() with spin_trylock_irqsave().

Fixes: 342a932 ("locking/spinlock: Provide RT variant header: <linux/spinlock_rt.h>")
Signed-off-by: Yeoreum Yun <yeoreum.yun@arm.com>
Reviewed-by: Simon Horman <horms@kernel.org>
Link: https://patch.msgid.link/20251217085115.1730036-1-yeoreum.yun@arm.com
Signed-off-by: Paolo Abeni <pabeni@redhat.com>
sgaud-quic pushed a commit to sgaud-quic/kernel that referenced this pull request Jan 27, 2026
@LeviYeoReum @gregkh
smc91x: fix broken irq-context in PREEMPT_RT
b6018d5 
[ Upstream commit 6402078 ]

When smc91x.c is built with PREEMPT_RT, the following splat occurs
in FVP_RevC:

[   13.055000] smc91x LNRO0003:00 eth0: link up, 10Mbps, half-duplex, lpa 0x0000
[   13.062137] BUG: workqueue leaked atomic, lock or RCU: kworker/2:1[106]
[   13.062137]      preempt=0x00000000 lock=0->0 RCU=0->1 workfn=mld_ifc_work
[   13.062266] C
** replaying previous printk message **
[   13.062266] CPU: 2 UID: 0 PID: 106 Comm: kworker/2:1 Not tainted 6.18.0-dirty qualcomm-linux#179 PREEMPT_{RT,(full)}
[   13.062353] Hardware name:  , BIOS
[   13.062382] Workqueue: mld mld_ifc_work
[   13.062469] Call trace:
[   13.062494]  show_stack+0x24/0x40 (C)
[   13.062602]  __dump_stack+0x28/0x48
[   13.062710]  dump_stack_lvl+0x7c/0xb0
[   13.062818]  dump_stack+0x18/0x34
[   13.062926]  process_scheduled_works+0x294/0x450
[   13.063043]  worker_thread+0x260/0x3d8
[   13.063124]  kthread+0x1c4/0x228
[   13.063235]  ret_from_fork+0x10/0x20

This happens because smc_special_trylock() disables IRQs even on PREEMPT_RT,
but smc_special_unlock() does not restore IRQs on PREEMPT_RT.
The reason is that smc_special_unlock() calls spin_unlock_irqrestore(),
and rcu_read_unlock_bh() in __dev_queue_xmit() cannot invoke
rcu_read_unlock() through __local_bh_enable_ip() when current->softirq_disable_cnt becomes zero.

To address this issue, replace smc_special_trylock() with spin_trylock_irqsave().

Fixes: 342a932 ("locking/spinlock: Provide RT variant header: <linux/spinlock_rt.h>")
Signed-off-by: Yeoreum Yun <yeoreum.yun@arm.com>
Reviewed-by: Simon Horman <horms@kernel.org>
Link: https://patch.msgid.link/20251217085115.1730036-1-yeoreum.yun@arm.com
Signed-off-by: Paolo Abeni <pabeni@redhat.com>
Signed-off-by: Sasha Levin <sashal@kernel.org>
@arakshit011
FROMGIT: arm64: dts: qcom: lemans: add QCrypto node
59d5881 
Add Qualcomm Crypto Engine device node for LeMans platform.

QCE and Crypto DMA nodes patch was applied as part of the
commit 7ff3da4 ("arm64: dts: qcom: sa8775p: add QCrypto nodes"),
however was partially reverted by commit 92979f1 ("arm64: dts: qcom:
sa8775p: Partially revert "arm64: dts: qcom: sa8775p: add QCrypto nodes"")
due to compatible-string being miss-matched against schema.

Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>
Link: https://lore.kernel.org/all/20251224-enable-qualcomm-crypto-engine-for-lemans-v2-1-a707e3d38765@oss.qualcomm.com/
Signed-off-by: Abhinaba Rakshit <abhinaba.rakshit@oss.qualcomm.com>
@qcomlnxci
Copy link

qcomlnxci commented Feb 3, 2026

Test jobs on 59d5881

@qcomlnxci
Copy link

qcomlnxci commented Feb 3, 2026

Tests-kaanapali-qrd

  • Total: 0 (✅ 0, ❌ 0, ⛔ 0, ⚠️ 0)

Tests-lemans-evk

  • Total: 31 (✅ 23, ❌ 6, ⛔ 0, ⚠️ 2)
    • Failures:
      • Probe_Failure_Check
      • USBHost
      • shmbridge
      • BT_FW_KMD_Service
      • BT_ON_OFF
      • BT_SCAN

Tests-qcs615-ride

  • Total: 0 (✅ 0, ❌ 0, ⛔ 0, ⚠️ 0)

Tests-qcs6490-rb3gen2

  • Total: 0 (✅ 0, ❌ 0, ⛔ 0, ⚠️ 0)

Tests-qcs8300-ride

  • Total: 31 (✅ 27, ❌ 2, ⛔ 0, ⚠️ 2)
    • Failures:
      • remoteproc
      • shmbridge

Tests-qcs9100-ride-r3

  • Total: 31 (✅ 28, ❌ 1, ⛔ 0, ⚠️ 2)
    • Failures:
      • shmbridge

Tests-sm8750-mtp

  • Total: 31 (✅ 18, ❌ 7, ⛔ 0, ⚠️ 6)
    • Failures:
      • cdsp_remoteproc
      • remoteproc
      • Probe_Failure_Check
      • Freq_Scaling
      • USBHost
      • shmbridge
      • BT_FW_KMD_Service

Tests-x1e80100-crd

  • Total: 0 (✅ 0, ❌ 0, ⛔ 0, ⚠️ 0)

@qcomlnxci
Copy link

qcomlnxci commented Feb 3, 2026

Tests-kaanapali-qrd

  • Total: 0 (✅ 0, ❌ 0, ⛔ 0, ⚠️ 0)

Tests-lemans-evk

  • Total: 0 (✅ 0, ❌ 0, ⛔ 0, ⚠️ 0)

Tests-qcs615-ride

  • Total: 0 (✅ 0, ❌ 0, ⛔ 0, ⚠️ 0)

Tests-qcs6490-rb3gen2

  • Total: 31 (✅ 27, ❌ 2, ⛔ 0, ⚠️ 2)
    • Failures:
      • USBHost
      • shmbridge

Tests-qcs8300-ride

  • Total: 0 (✅ 0, ❌ 0, ⛔ 0, ⚠️ 0)

Tests-qcs9100-ride-r3

  • Total: 31 (✅ 28, ❌ 1, ⛔ 0, ⚠️ 2)
    • Failures:
      • shmbridge

Tests-sm8750-mtp

  • Total: 31 (✅ 18, ❌ 7, ⛔ 0, ⚠️ 6)
    • Failures:
      • cdsp_remoteproc
      • BT_FW_KMD_Service
      • remoteproc
      • Probe_Failure_Check
      • Freq_Scaling
      • USBHost
      • shmbridge

Tests-x1e80100-crd

  • Total: 0 (✅ 0, ❌ 0, ⛔ 0, ⚠️ 0)

@qcomlnxci
Copy link

qcomlnxci commented Feb 3, 2026

Test jobs on 59d5881

@qcomlnxci
Copy link

qcomlnxci commented Feb 4, 2026

Test jobs on 59d5881

@qcomlnxci
Copy link

qcomlnxci commented Feb 4, 2026

Tests-kaanapali-qrd

  • Total: 0 (✅ 0, ❌ 0, ⛔ 0, ⚠️ 0)

Tests-lemans-evk

  • Total: 31 (✅ 25, ❌ 4, ⛔ 0, ⚠️ 2)
    • Failures:
      • Probe_Failure_Check
      • USBHost
      • shmbridge
      • BT_FW_KMD_Service

Tests-qcs615-ride

  • Total: 0 (✅ 0, ❌ 0, ⛔ 0, ⚠️ 0)

Tests-qcs6490-rb3gen2

  • Total: 31 (✅ 27, ❌ 2, ⛔ 0, ⚠️ 2)
    • Failures:
      • USBHost
      • shmbridge

Tests-qcs8300-ride

  • Total: 31 (✅ 27, ❌ 2, ⛔ 0, ⚠️ 2)
    • Failures:
      • shmbridge
      • remoteproc

Tests-qcs9100-ride-r3

  • Total: 31 (✅ 28, ❌ 1, ⛔ 0, ⚠️ 2)
    • Failures:
      • shmbridge

Tests-sm8750-mtp

  • Total: 31 (✅ 18, ❌ 7, ⛔ 0, ⚠️ 6)
    • Failures:
      • USBHost
      • shmbridge
      • BT_FW_KMD_Service
      • Probe_Failure_Check
      • Freq_Scaling
      • cdsp_remoteproc
      • remoteproc

Tests-x1e80100-crd

  • Total: 0 (✅ 0, ❌ 0, ⛔ 0, ⚠️ 0)

@sgaud-quic sgaud-quic merged commit 314cab6 into qualcomm-linux:qcom-6.18.y Feb 4, 2026
9 of 11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@shashim-quic shashim-quic shashim-quic approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@arakshit011 @qcomlnxci @shashim-quic @sgaud-quic