Skip to content

qcom-tee: add a library for security feature support #1167

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
ricardosalveti merged 1 commit into from
Nov 19, 2025
Merged

qcom-tee: add a library for security feature support #1167

ricardosalveti merged 1 commit into from
Nov 19, 2025

Conversation

@jiaxli-QC
Copy link

@jiaxli-QC jiaxli-QC commented Oct 29, 2025 •
edited
Loading

The QCOM-TEE library introduces an interface that facilitates secure communication with QTEE, supporting security feature integration.
Add the qcom-tee library to dynamic-layer because it depends on the qcobr library from the meta-openembedded dynamic layer.

@jiaxli-QC
Copy link
Author

jiaxli-QC commented Oct 29, 2025

Hi reviewer, this PR has been separated from PR1049. Following our internal discussion, we have decided to share the qcbor, qcom-teec, and minkipc components individually.
Our expected merge order is:

  1. qcbor: qcbor: library to expose Qualcomm Security Package #1166
  2. qcom-teec: qcom-tee: add a library for security feature support #1167
  3. Minkipc: minkipc: Add libraries and applications for security feature support #1094

@jiaxli-QC jiaxli-QC mentioned this pull request Oct 29, 2025
Closed
vksharma-oss
vksharma-oss reviewed Oct 29, 2025
View reviewed changes
lumag
lumag requested changes Oct 29, 2025
View reviewed changes
Copy link
Contributor

@lumag lumag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please write a proper commit subject and commit message. Use git log to get an inspiration.

ricardosalveti
ricardosalveti reviewed Oct 30, 2025
View reviewed changes
ricardosalveti
ricardosalveti reviewed Oct 30, 2025
View reviewed changes
ricardosalveti
ricardosalveti reviewed Oct 30, 2025
View reviewed changes
ricardosalveti
ricardosalveti reviewed Oct 30, 2025
View reviewed changes
@ricardosalveti
Copy link
Contributor

ricardosalveti commented Nov 6, 2025

As described at #1166 (comment) this recipe needs to be under dynamic-layers/openembedded-layer.

@jiaxli-QC jiaxli-QC force-pushed the QcomteecEnable branch 2 times, most recently from 623077f to 1267e17 Compare November 10, 2025 02:40
@jiaxli-QC
Copy link
Author

jiaxli-QC commented Nov 10, 2025

As described at #1166 (comment) this recipe needs to be under dynamic-layers/openembedded-layer.

Yes, updated the path

@jiaxli-QC
Copy link
Author

jiaxli-QC commented Nov 13, 2025 •
edited
Loading

Hi @ricardosalveti , @lumag , Could you help review this PR? I’ve made some optimizations to the change.
Dropped the test client and just provided a library for MinkIPC compilation support.

koenkooi
koenkooi requested changes Nov 17, 2025
View reviewed changes
Copy link
Contributor

@koenkooi koenkooi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The first line of the commit message needs changing to the "subject: explanation" format, e.g:

qcom-tee: Add library for security feature support

Also: please mention why it goes into dynamic-layers in the commit message.

@jiaxli-QC jiaxli-QC changed the title Add qcomtee library for security feature support qcom-tee: add a library for security feature support Nov 17, 2025
@jiaxli-QC
Copy link
Author

jiaxli-QC commented Nov 17, 2025

The first line of the commit message needs changing to the "subject: explanation" format, e.g:

qcom-tee: Add library for security feature support

Also: please mention why it goes into dynamic-layers in the commit message.

Updated the commit message. Many thanks for your comments.

@jiaxli-QC jiaxli-QC requested a review from koenkooi November 17, 2025 08:45
koenkooi
koenkooi previously approved these changes Nov 17, 2025
View reviewed changes
@jiaxli-QC jiaxli-QC requested a review from koenkooi November 17, 2025 09:55
vksharma-oss
vksharma-oss approved these changes Nov 17, 2025
View reviewed changes
Copy link

@vksharma-oss vksharma-oss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change looks good. qcbor dependency coming from meta-qcom-distro from meta-oe.

lumag
lumag previously approved these changes Nov 17, 2025
View reviewed changes
@lumag lumag enabled auto-merge November 17, 2025 10:12
@lumag
Copy link
Contributor

lumag commented Nov 17, 2025

Fails to build from source:

2025-11-17 11:38:33 - INFO     - | /work/build/tmp/work/cortexa15t2hf-neon-vfpv4-qcom-linux-gnueabi/qcomtee/0.0+git/sources/qcomtee-0.0+git/libqcomtee/src/qcomtee_object.c: In function 'qcomtee_object_cb_marshal_in':
2025-11-17 11:38:33 - INFO     - | /work/build/tmp/work/cortexa15t2hf-neon-vfpv4-qcom-linux-gnueabi/qcomtee/0.0+git/sources/qcomtee-0.0+git/libqcomtee/src/qcomtee_object.c:574:47: error: cast to pointer from integer of different size [-Werror=int-to-pointer-cast]
2025-11-17 11:38:33 - INFO     - |   574 |                         params[i].ubuf.addr = (void *)tee_params[i].a;
2025-11-17 11:38:33 - INFO     - |       |

@ricardosalveti
Copy link
Contributor

ricardosalveti commented Nov 17, 2025

Never built-tested on armv7?

@jiaxli-QC
Copy link
Author

jiaxli-QC commented Nov 18, 2025

Never built-tested on armv7?

Yes, we haven't compiled this change on armv7. Is there a test script available for all platforms?

@jiaxli-QC
Copy link
Author

jiaxli-QC commented Nov 18, 2025

Fails to build from source:

2025-11-17 11:38:33 - INFO     - | /work/build/tmp/work/cortexa15t2hf-neon-vfpv4-qcom-linux-gnueabi/qcomtee/0.0+git/sources/qcomtee-0.0+git/libqcomtee/src/qcomtee_object.c: In function 'qcomtee_object_cb_marshal_in':
2025-11-17 11:38:33 - INFO     - | /work/build/tmp/work/cortexa15t2hf-neon-vfpv4-qcom-linux-gnueabi/qcomtee/0.0+git/sources/qcomtee-0.0+git/libqcomtee/src/qcomtee_object.c:574:47: error: cast to pointer from integer of different size [-Werror=int-to-pointer-cast]
2025-11-17 11:38:33 - INFO     - |   574 |                         params[i].ubuf.addr = (void *)tee_params[i].a;
2025-11-17 11:38:33 - INFO     - |       |

I have raised a PR for quic-teec repo to fix this compilation issue. quic/quic-teec#22

qcom-tee: add a library for security feature support
378ec52 
The qcom-tee library introduces an interface that facilitates secure
communication with QTEE, supporting security feature integration.
Add the qcom-tee library to dynamic-layer because it depends on the
qcobr library from the meta-openembedded dynamic layer.

Signed-off-by: Jiaxing Li <[email protected]>
auto-merge was automatically disabled November 18, 2025 07:48

Head branch was pushed to by a user without write access

@jiaxli-QC jiaxli-QC dismissed stale reviews from lumag and koenkooi via 378ec52 November 18, 2025 07:48
@jiaxli-QC
Copy link
Author

jiaxli-QC commented Nov 18, 2025

Fixed the compilation issue, and the target was built successfully using the following commands, pls review it again:

kas build meta-qcom/ci/qcs6490-rb3gen2-core-kit.yml:meta-qcom/ci/qcom-distro.yml --target qcomtee
kas build meta-qcom/ci/qcom-armv8a.yml:meta-qcom/ci/qcom-distro.yml --target qcomtee
kas build meta-qcom/ci/qcom-armv8a.yml:meta-qcom/ci/qcom-distro-prop-image.yml --target qcomtee
kas build meta-qcom/ci/qcom-armv7a.yml:meta-qcom/ci/qcom-distro.yml --target qcomtee

Many thanks.

@jiaxli-QC
Copy link
Author

jiaxli-QC commented Nov 18, 2025

I updated the line SRCREV = "a40de2d23dc04f2fad144315848c31e70c869d3d" since the quic-teec version changed to resolve the compilation issue.

@github-actions
Copy link

github-actions bot commented Nov 18, 2025

Test run workflow

Test jobs for commit 378ec52

@github-actions
Copy link

github-actions bot commented Nov 18, 2025 •
edited
Loading

Test Results

 14 files  ±0   28 suites  ±0   28m 54s ⏱️ -57s
 50 tests ±0   50 ✅ ±0  0 💤 ±0  0 ❌ ±0 
304 runs  ±0  304 ✅ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit 378ec52. ± Comparison against base commit dcc46e3.

♻️ This comment has been updated with latest results.

@github-actions
Copy link

github-actions bot commented Nov 18, 2025

Test run workflow

Test jobs for commit 378ec52

@ricardosalveti ricardosalveti merged commit 81d6358 into qualcomm-linux:master Nov 19, 2025
80 of 81 checks passed
@jiaxli-QC jiaxli-QC mentioned this pull request Dec 10, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ricardosalveti ricardosalveti ricardosalveti approved these changes

@vkraleti vkraleti vkraleti approved these changes

@sbanerjee-quic sbanerjee-quic Awaiting requested review from sbanerjee-quic sbanerjee-quic is a code owner

@ndechesne ndechesne Awaiting requested review from ndechesne ndechesne is a code owner

@koenkooi koenkooi Awaiting requested review from koenkooi

@lumag lumag Awaiting requested review from lumag lumag is a code owner

@vksharma-oss vksharma-oss Awaiting requested review from vksharma-oss

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@jiaxli-QC @ricardosalveti @lumag @koenkooi @vkraleti @vksharma-oss