Skip to content

Rb3gen2: Add support for Open Boot firmware (TF-A, OP-TEE and U-Boot) build #1172

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
b49020 wants to merge 7 commits into
base: master
Choose a base branch
from
Open

Rb3gen2: Add support for Open Boot firmware (TF-A, OP-TEE and U-Boot) build #1172

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
074bc4f
layer.conf: add meta-arm to LAYERDEPENDS
b49020 Oct 30, 2025
297f464
recipes-bsp: Add trusted-firmware-a support for RB3Gen2
b49020 Oct 29, 2025
d25d38f
recipes-security: Add OP-TEE recipes override for RB3Gen2
b49020 Oct 29, 2025
aa97c88
qcs6490-rb3gen2: Add U-Boot support for RB3Gen2
b49020 Oct 29, 2025
beff201
qcs6490-rb3gen2: Add support for open firmware machine features
b49020 Oct 31, 2025
5b04d7e
CI: Add KAS yaml file to build open boot firmware stack
b49020 Oct 30, 2025
2376dc9
github/workflows: Extend CI to compile open boot firmware for RB3Gen2
b49020 Oct 30, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions ci/base.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,12 @@ repos:
layers:
meta-poky:

meta-arm:
url: https://git.yoctoproject.org/meta-arm
layers:
meta-arm:
meta-arm-toolchain:
Copy link
Contributor

@lumag lumag Nov 7, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So, building has beek broken for all previous commits. That's not nice

Copy link
Member Author

@b49020 b49020 Nov 10, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's a fair point, I will move this diff to first patch instead.


local_conf_header:
base: |
CONF_VERSION = "2"
Expand Down
8 changes: 8 additions & 0 deletions ci/open-boot-firmware.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,8 @@
# yaml-language-server: $schema=https://raw.githubusercontent.com/siemens/kas/master/kas/schema-kas.json

header:
version: 14

local_conf_header:
firmware: |
MACHINE_FEATURES:qcm6490:append = " tfa optee u-boot"
Copy link
Contributor

@ndechesne ndechesne Nov 7, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know if it's a functional difference or not.. but we usually put the :append or :prepend first in the list of overrides.

Copy link
Contributor

@ndechesne ndechesne Nov 7, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't like changing the MACHINE config in the KAS config file. I would rather have a difference machine, what do you think?

Copy link
Member Author

@b49020 b49020 Nov 7, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think having a different machine makes sense here. Since here we are building a different boot firmware (open vs closed source) for the same machine like we do for supporting different kernel versions for the same machine.

but we usually put the :append or :prepend first in the list of overrides.

Sure, I will fix that.

Copy link
Contributor

@lumag lumag Nov 7, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know if it's a functional difference or not.. but we usually put the :append or :prepend first in the list of overrides.

It is: foo:soc:append appends to foo:soc, which then override full foo value. foo:append:soc: makes foo:append work only on soc, which then appends to the existing foo variable without redefining it completely.

I also don't like the idea of changing MACHINE_FEATURES here. I'd prefer if we have enabled MACHINE_FEATURES for all machines that support TF-A and then used COMBINED_FEATURES in order to determine whether to use a normal boot flow or a TF-A based one.

Copy link
Contributor

@ndechesne ndechesne Nov 7, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like the COMBINED_FEATURES.
We will then need to decide if we have an 'open boot' distro ;)

Copy link
Member Author

@b49020 b49020 Nov 10, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It feels like we are moving in a direction to build open boot firmware and package closed boot firmware during a common build like for RB3Gen2 in this case. The build artifacts will contain both but what is present in the device flashing tarball is based on open-boot feature present in COMBINED_FEATURES. Does that sound reasonable?