camxcommon: package provide common utility API used by all CamX components #1231
Conversation
gkhose-qipl
requested review from
lumag,
ndechesne,
ricardosalveti,
sbanerjee-quic and
vkraleti
as code owners
lumag
left a comment
lumag
left a comment
There was a problem hiding this comment.
I reviewed the first recipe. Please apply that to all recipes in the PR
| @@ -0,0 +1,21 @@ | |||
| SUMMARY = "Qualcomm camera core driver and pipeline related libraries" | |||
There was a problem hiding this comment.
Please write a proper commit message. Describe your design decisions, issues, etc. It should be a text, rather than a bullet list.
There was a problem hiding this comment.
This is still not addressed.
| @@ -0,0 +1,21 @@ | |||
| SUMMARY = "Qualcomm camera core driver and pipeline related libraries" | |||
| DESCRIPTION = "Collection of prebuilt libraries to support camera downstream functionality." | |||
| LICENSE = "CLOSED" | |||
There was a problem hiding this comment.
Please add a proper license. It should actual use and distribution terms.
| SRC_URI = "https://qartifactory-edge.qualcomm.com/artifactory/qsc_releases/software/chip/component/camx.qclinux.0.0/251120/prebuilt_yocto/${BPN}_${PV}_armv8-2a.tar.gz;subdir=${BPN}-${PV}" | ||
| SRC_URI[sha256sum] = "c0b2f23c0c87df6b113466b83948cf2baf80b38492e1899984193108a0bab8e3" | ||
|
|
||
| DEPENDS += "camxfirmware fastrpc protobuf-native protobuf protobuf-native libxml2 virtual/egl virtual/libgles2" |
There was a problem hiding this comment.
No, libs don't depend on the firmware. Especially not at the build time.
|
Please break into more commits, one single commit adding a bunch of recipes is not ideal. |
gkhose-qipl
force-pushed
the
camx_downstream
branch
2 times, most recently
from
64768be to
78cfd3c
Compare
| @@ -0,0 +1,18 @@ | |||
| SUMMARY = "Qualcomm camera development related libraries, binary" | |||
| DESCRIPTION = "Collection of prebuilt libraries to support camera downstream functionality." | |||
There was a problem hiding this comment.
Summary and description for most recipes are quite similar here, you should make it cover just this component (explain why it exists).
There was a problem hiding this comment.
Like, what chicdk even means?
| @@ -0,0 +1,18 @@ | |||
| SUMMARY = "Qualcomm camera development related libraries, binary" | |||
| DESCRIPTION = "Collection of prebuilt libraries to support camera downstream functionality." | |||
| LICENSE = "CLOSED" | |||
There was a problem hiding this comment.
Need proper license.
Also add NOTICE (from the tarball) in LIC_FILES_CHKSUM.
|
Please. Test your changes before sending the PR. Building |
|
Also, please fix your build system: |
lumag
left a comment
lumag
left a comment
There was a problem hiding this comment.
On top of everything. Please rename the packages in a sensible way.
Instead of -kt use -kodiak. Likewise add sensible suffix to qcs9100-related packages.
| @@ -0,0 +1,19 @@ | |||
| SUMMARY = "Qualcomm camera common utility API used by camera driver" | |||
There was a problem hiding this comment.
This package includes files under /usr/lib/qcs9100/. Why are they a part of this package? Why is it split from camxlib?
There was a problem hiding this comment.
Also, we are definitely going to have several other versions of camx-something. Please name all packages according to platforms they support.
There was a problem hiding this comment.
These comments were totally ignored.
gkhose-qipl
force-pushed
the
camx_downstream
branch
from
78cfd3c to
3ff362b
Compare
gkhose-qipl
changed the title
gkhose-qipl
force-pushed
the
camx_downstream
branch
from
3ff362b to
2c40208
Compare
Commit subject: what actually happens. `camxcommon: add libs common to foo, bar and baz'. Or 'used by foo, bar and baz'. Commit message: English text. Not a bullet list. Not a list of changes in the commit, we can read patches. Describe why it needs to be done and why it needs to be done this particular way. |
so what can be good way to name recipe. camx-kodiak, camx-talos , camx-lemans-monaco? |
if we need to use RPROVIDES , what should be recipe name ? |
camx-lemans_1.0.1.bb, |
|
As a side note I'll probably ask to use codenames for SoC subdirs. We have had enough troubles and confusion about qcs6490 vs qcs6490 vs sc7280, qrb5165 vs sm8250, etc. Using the codenames removes the topic as it points out that this CamX works for all kodiak instances, no matter if it is compute, mobile, IoT or something else. |
Is the expectation described below correct, or do I need to update the approach?
|
gkhose-qipl
force-pushed
the
camx_downstream
branch
from
f7ea0fd to
ce2d738
Compare
lumag
left a comment
lumag
left a comment
There was a problem hiding this comment.
Which cirtular dependnecies? Which compilation?? We are not building anything here.
CamX driver (aka DLKM) doesn't depend on any userspace components, so the commit message is not correct.
Last, but not least, please wrap your commit messages sensibly, at 72-75 chars boundary. If you are using ViM it does that for you. If you are using any other editor, please fix its configuration.
|
Colleagues. I'm starting to be really angry. Why did the version go BACKWARDS?? |
gkhose-qipl
force-pushed
the
camx_downstream
branch
from
ce2d738 to
0979b47
Compare
done, updated to 1.0.3 as last version was 1.0.2 |
gkhose-qipl
force-pushed
the
camx_downstream
branch
from
0979b47 to
84daf9e
Compare
That's not an answer to the 'Why?' question. |
gkhose-qipl
force-pushed
the
camx_downstream
branch
from
84daf9e to
57d0c52
Compare
@lumag , |
Why are you again talking about recipes? The question is about release versions. |
release version for all QLI release was 1.0.0 in hwe. |
Test run workflowTest jobs for commit 57d0c52
|
|
@lumag / @ricardosalveti / @koenkooi , |
| This package provides the foundational utility libraries shared across all \ | ||
| components of the Qualcomm Camera X (CamX). It is separated \ | ||
| from the main qcom-camx package to resolve build dependencies, as these \ | ||
| utilities are required by camx, chi-cdk, and camx-lib during compilation." |
There was a problem hiding this comment.
Again, this doesn't make sense. We don't perform builds here.
It might help if you explain, what are the components. What is chi-cdk? Who uses it? What is the difference between camx and camx-lib? Doesn't camx depend on camx-lib? Does chi-cdk depend on camx? On camx-lib?
There was a problem hiding this comment.
I mean, explain here, in the comment (or in the commit message). Not in the package description.
There was a problem hiding this comment.
I mean, explain here, in the comment (or in the commit message). Not in the package description.
I'd say even the description here should be something that people with little background can understand when looking at just the description embedded in package, so no short forms if possible like chi-cdk.
There was a problem hiding this comment.
Again, this doesn't make sense. We don't perform builds here.
It might help if you explain, what are the components. What is chi-cdk? Who uses it? What is the difference between camx and camx-lib? Doesn't camx depend on camx-lib? Does chi-cdk depend on camx? On camx-lib?
Dependency flow.
camxcommon
camxlib (depends on camxcommon)
camx (depends on camxlib)
chicdk (depnds on camx)
chi-cdk:- (Camera Hardware Interface Customization Development Kit).
did not get "Who uses it? " can you please elaborate
gkhose-qipl
force-pushed
the
camx_downstream
branch
from
57d0c52 to
5dafec0
Compare
| from the main qcom-camx package as these utilities are required by camx, \ | ||
| chi-cdk, and camx-lib during compilation." | ||
| LICENSE = "LICENSE.qcom-2" | ||
| LIC_FILES_CHKSUM = "file://${UNPACKDIR}/usr/share/doc/${BPN}/NO.LOGIN.BINARY.LICENSE.QTI.pdf;md5=7a5da794b857d786888bbf2b7b7529c8" |
There was a problem hiding this comment.
Drop the file://${UNPACKDIR}
There was a problem hiding this comment.
sure will update with below, is that fine ?
LIC_FILES_CHKSUM = "file://usr/share/doc/${BPN}/NO.LOGIN.BINARY.LICENSE.QTI.pdf;md5=7a5da794b857d786888bbf2b7b7529c8"
Test run workflowTest jobs for commit 5dafec0
|
The camx-common package provides foundational utility libraries that are shared across all components of the Qualcomm Camera X (CamX) This package is separated from the main camx library as these utilities are required by both the core camx driver, the CHI (Camera Hardware Interface) CDK framework, and various camera library components during their build process. It includes three essential components: a settings manager for runtime configuration management, common utility functions for memory management and logging, and a hierarchical settings framework that combines platform-specific configs with common default configurations. Signed-off-by: Ganesh Khose <[email protected]>
gkhose-qipl
force-pushed
the
camx_downstream
branch
from
5dafec0 to
b6d1da7
Compare
Test run workflowTest jobs for commit b6d1da7
|
6 participants
The camx-common package provides foundational utility libraries that are shared across all components of the Qualcomm Camera X (CamX)
This package is separated from the main camx library as these utilities are required by both the core camx driver,
the CHI (Camera Hardware Interface) CDK framework, and various camera library components during their build process.
It includes three essential components: a settings manager for runtime configuration management, common utility functions for memory management and logging, and a hierarchical settings framework that combines platform-specific configs with common default configurations