opencv: add DEPENDS on qcom-fastcv-binaries for qcom aarch64 builds #1271
Conversation
quic-ptak
requested review from
lumag,
ndechesne,
ricardosalveti,
sbanerjee-quic and
vkraleti
as code owners
Test run workflowTest jobs for commit 2d2c840
|
quic-ptak
changed the title
dynamic-layers/openembedded-layer/recipes-support/opencv/opencv_%.bbappend
Outdated
Show resolved
Hide resolved
Test run workflowTest jobs for commit 9d31a57
|
Test Results 14 files ±0 28 suites +1 36m 19s ⏱️ - 7m 57s Results for commit 2d85e52. ± Comparison against base commit 376521a. This pull request removes 2 tests.♻️ This comment has been updated with latest results. |
Test run workflowTest jobs for commit 9d31a57
|
Test run workflowTest jobs for commit 9d31a57
|
quic-ptak
changed the title
quic-ptak
force-pushed
the
master
branch
2 times, most recently
from
f259f98 to
2d85e52
Compare
Test run workflowTest jobs for commit f259f98
|
Test run workflowTest jobs for commit 2d85e52
|
Test run workflowTest jobs for commit 2d85e52
|
koenkooi
left a comment
koenkooi
left a comment
There was a problem hiding this comment.
LGTM. For future recipes, a comment next to the DEPENDS line explaining about OE shlib resolution could avoid confusion. But that isn't needed for this to go in.
dynamic-layers/openembedded-layer/recipes-support/opencv/opencv_%.bbappend
Outdated
Show resolved
Hide resolved
dynamic-layers/openembedded-layer/recipes-support/opencv/opencv_%.bbappend
Outdated
Show resolved
Hide resolved
dynamic-layers/openembedded-layer/recipes-support/opencv/opencv_%.bbappend
Outdated
Show resolved
Hide resolved
Dynamic OpenCV packages such as libopencv_core, libopencv_fastcv, and libopencv_imgproc now include FastCV DSP functionality. These components require libfastcvopt.so as the entry point for the pipeline, which is provided by qcom-fastcv-binaries. Signed-off-by: Pulkit Singh Tak <[email protected]>
|
It probably should have come up earlier during review. Should this be handled in the main opencv recipe instead? I'm fine with enabling 'fastcv' in our bbappend, but the code for the |
In our opinion, OpenCV recipe should contain general configs only and not any vendor specific changes. Since FastCV works only with QCOM specific boards, we ought to mention all FastCV based configs (DEPENDS, RDEPENDS) in meta-qcom based bbappend . |
If possible, can we do it in next PR? We have a deadline approaching. |
In which PR? meta-oe uses emails for patches. |
I mean, once we merge the packageconfig patch to meta-oe, we can raise another PR to remove DEPENDS and RDEPENDS from this .bbappend |
Any thoughts on this @lumag |
|
also adding RDEPENDS to libfastcvopt1 is causing below QA errors: ERROR - ERROR: opencv-4.12.0-r0 do_package_qa: QA Issue: libopencv-core rdepends on libfastcvopt1, but it isn't a build dependency? [build-deps] which are resolved when we do RDEPENDS to qcom-fastcv-binaries |
Add qcom-fastcv-binaries to DEPENDS |
But to provide FastCV DSP functionality, we also need libfastcvopt.so for entry point provided by "qcom-fastcv-binaries" asmentioned in previous discussions. Can we also RDEPENDS on "qcom-fastcv-binaries" ? |
There is no such package |
in our local workspace the package is there : ptak@hu-ptak-hyd:/local/mnt/workspace/ptak/QSBT/qli_dsp/build$ bitbake -e qcom-fastcv-binaries | grep ^PACKAGES= Only during creation of ipks the name is being changed to libfastcvopt1 but original package still remains. |
You basically wrote that there is no such package. It gets renamed. I will send a patch to meta-oe. |
And I was wrong here. insane.bbclass doesn't resolve runtime-renamed packages. |
4 participants
Dynamic OpenCV packages such as libopencv_core, libopencv_fastcv, and libopencv_imgproc now include FastCV DSP functionality. These components require libfastcvopt.so as the entry point for the pipeline, which is provided by qcom-fastcv-binaries.