Skip to content

Conversation

@WeiDeng-weiden
Copy link

Enable as modules the BT_BNEP and BT_RFCOMM drivers which are required for Bluetooth profiles such as PAN and SPP. Without these modules, PAN and SPP functionality will not be available. Enable UHID support to allow HID over GATT operations. Without this, user-space cannot create virtual HID devices, which impacts HID profile usage over Bluetooth.

Copy link
Contributor

@lumag lumag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

s/ config//

@github-actions
Copy link

github-actions bot commented Dec 3, 2025

Test run workflow

Test jobs for commit 7ff739f

@test-reporting-app
Copy link

test-reporting-app bot commented Dec 3, 2025

Test Results

 14 files  ± 0   28 suites  +1   38m 25s ⏱️ - 36m 56s
 50 tests  -  3   50 ✅ + 2  0 💤 ±0  0 ❌  - 5 
304 runs  +13  304 ✅ +18  0 💤 ±0  0 ❌  - 5 

Results for commit 0211486. ± Comparison against base commit f1e6892.

This pull request removes 3 tests.
lava ‑ downloads
lava ‑ lava-overlay
lava ‑ test-definition

♻️ This comment has been updated with latest results.

@WeiDeng-weiden
Copy link
Author

s/ config//

Thanks for the review.

For the comment s/ config//, could you please clarify which config you would like me to remove?

@lumag
Copy link
Contributor

lumag commented Dec 4, 2025

s/ config//

Thanks for the review.

For the comment s/ config//, could you please clarify which config you would like me to remove?

I see only one place where the regexp is applicable.

@WeiDeng-weiden
Copy link
Author

s/ config//

Thanks for the review.
For the comment s/ config//, could you please clarify which config you would like me to remove?

I see only one place where the regexp is applicable.

Here is my current diff:
Could you please point out the exact line (file and line number) where you’d like me to remove config, or let me know if this comment can be ignored with the latest patch set?

diff --git a/recipes-kernel/linux/linux-qcom-next/configs/qcom.cfg b/recipes-kernel/linux/linux-qcom-next/configs/qcom.cfg
index b5a294f..837a6aa 100644
--- a/recipes-kernel/linux/linux-qcom-next/configs/qcom.cfg
+++ b/recipes-kernel/linux/linux-qcom-next/configs/qcom.cfg
@@ -308,3 +308,11 @@ CONFIG_NFT_TPROXY=m
CONFIG_NFT_TUNNEL=m
CONFIG_PACKET_DIAG=y
CONFIG_VETH=m
+
+# Enable BT_RFCOMM, BT_BNEP and UHID
+CONFIG_BT_BNEP=m
+CONFIG_BT_BNEP_MC_FILTER=y
+CONFIG_BT_BNEP_PROTO_FILTER=y
+CONFIG_BT_RFCOMM=m
+CONFIG_BT_RFCOMM_TTY=y
+CONFIG_UHID=m

@lumag
Copy link
Contributor

lumag commented Dec 4, 2025

s/ config//

Thanks for the review.
For the comment s/ config//, could you please clarify which config you would like me to remove?

I see only one place where the regexp is applicable.

Here is my current diff: Could you please point out the exact line (file and line number) where you’d like me to remove config, or let me know if this comment can be ignored with the latest patch set?

You've posted a diff, but it's not a full patch. There is an extra " config" in the commit subject.

@WeiDeng-weiden
Copy link
Author

s/ config//

Thanks for the review.
For the comment s/ config//, could you please clarify which config you would like me to remove?

I see only one place where the regexp is applicable.

Here is my current diff: Could you please point out the exact line (file and line number) where you’d like me to remove config, or let me know if this comment can be ignored with the latest patch set?

You've posted a diff, but it's not a full patch. There is an extra " config" in the commit subject.

OK, will remove config in the commit subject.

@WeiDeng-weiden WeiDeng-weiden changed the title linux-qcom-next config: Enable BT_RFCOMM, BT_BNEP and UHID linux-qcom-next: Enable BT_RFCOMM, BT_BNEP and UHID Dec 4, 2025
@ricardosalveti
Copy link
Contributor

Please rebase, build failure is related to the mesa updates (fixed in master).

Enable as modules the BT_BNEP and BT_RFCOMM drivers
which are required for Bluetooth profiles such as PAN
and SPP. Without these modules, PAN and SPP functionality
will not be available. Enable UHID support to allow HID
over GATT operations. Without this, user-space cannot
create virtual HID devices, which impacts HID profile
usage over Bluetooth.

Signed-off-by: Wei Deng <[email protected]>
@WeiDeng-weiden
Copy link
Author

Please rebase, build failure is related to the mesa updates (fixed in master).

Rebased and re-submitted.

@github-actions
Copy link

github-actions bot commented Dec 5, 2025

Test run workflow

Test jobs for commit 0211486

Copy link
Contributor

@lumag lumag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

At a second consideration: please send these changes to the upstream Linux kernel, then backport them to qcom-next as usual. There is nothing distro-specific nor BSP-specific in these Kconfig entries.

@WeiDeng-weiden
Copy link
Author

At a second consideration: please send these changes to the upstream Linux kernel, then backport them to qcom-next as usual. There is nothing distro-specific nor BSP-specific in these Kconfig entries.

Sure, will send to upstream then get back.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants