-
Notifications
You must be signed in to change notification settings - Fork 157
linux-qcom-next: Enable BT_RFCOMM, BT_BNEP and UHID #1278
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
lumag
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
s/ config//
Test run workflowTest jobs for commit 7ff739f
|
Test Results 14 files ± 0 28 suites +1 38m 25s ⏱️ - 36m 56s Results for commit 0211486. ± Comparison against base commit f1e6892. This pull request removes 3 tests.♻️ This comment has been updated with latest results. |
Thanks for the review. For the comment |
I see only one place where the regexp is applicable. |
Here is my current diff: diff --git a/recipes-kernel/linux/linux-qcom-next/configs/qcom.cfg b/recipes-kernel/linux/linux-qcom-next/configs/qcom.cfg |
You've posted a diff, but it's not a full patch. There is an extra " config" in the commit subject. |
OK, will remove config in the commit subject. |
7ff739f to
f7c6890
Compare
|
Please rebase, build failure is related to the mesa updates (fixed in master). |
Enable as modules the BT_BNEP and BT_RFCOMM drivers which are required for Bluetooth profiles such as PAN and SPP. Without these modules, PAN and SPP functionality will not be available. Enable UHID support to allow HID over GATT operations. Without this, user-space cannot create virtual HID devices, which impacts HID profile usage over Bluetooth. Signed-off-by: Wei Deng <[email protected]>
f7c6890 to
0211486
Compare
Rebased and re-submitted. |
Test run workflowTest jobs for commit 0211486
|
lumag
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
At a second consideration: please send these changes to the upstream Linux kernel, then backport them to qcom-next as usual. There is nothing distro-specific nor BSP-specific in these Kconfig entries.
Sure, will send to upstream then get back. |
Enable as modules the BT_BNEP and BT_RFCOMM drivers which are required for Bluetooth profiles such as PAN and SPP. Without these modules, PAN and SPP functionality will not be available. Enable UHID support to allow HID over GATT operations. Without this, user-space cannot create virtual HID devices, which impacts HID profile usage over Bluetooth.