Skip to content

sensors: add recipe for sensors prebuilt binaries #1298

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
bmasta018 wants to merge 1 commit into
base: master
Choose a base branch
from
Open

sensors: add recipe for sensors prebuilt binaries #1298

bmasta018 wants to merge 1 commit into from

Conversation

@bmasta018
Copy link
Contributor

@bmasta018 bmasta018 commented Dec 9, 2025

Add new recipe for Qualcomm Sensors Proprietary modules which provides sensors streaming data to Sensing Hub.

koenkooi
koenkooi requested changes Dec 9, 2025
View reviewed changes
dynamic-layers/openembedded-layer/recipes-support/sensors/qcom-sensors-binaries_1.0.1.bb Outdated
DESCRIPTION = "Prebuilt libraries and test applications for sensors services"
LICENSE = "LICENSE.qcom-2"
LIC_FILES_CHKSUM = "file://${UNPACKDIR}/usr/share/doc/sensors/NO.LOGIN.BINARY.LICENSE.QTI.pdf;md5=7a5da794b857d786888bbf2b7b7529c8"
SRC_URI = "https://qartifactory-edge.qualcomm.com/artifactory/qsc_releases/software/chip/component/sensors.lnx.0.0/${PBT_BUILD_DATE}/prebuilt_yocto/qcom-sensors-prebuilts_${PV}_armv8a.tar.gz"
Copy link
Contributor

@koenkooi koenkooi Dec 9, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please move the declaration of PBT_BUILD_DATE before its first use.

Copy link
Contributor

@lumag lumag Dec 9, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why? I think it makes sense. I usually ask to have PBT_BUILD_DATE grouped together with the sha256sum as those two change together.

ricardosalveti
ricardosalveti reviewed Dec 9, 2025
View reviewed changes
dynamic-layers/openembedded-layer/recipes-support/sensors/qcom-sensors-binaries_1.0.1.bb Outdated
@@ -0,0 +1,66 @@
SUMMARY = "Prebuilt Qualcomm sensors libraries and test applications"
DESCRIPTION = "Prebuilt libraries and test applications for sensors services"
Copy link
Contributor

@ricardosalveti ricardosalveti Dec 9, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add a proper description of what these libraries and test applications are actually doing, this is just too generic.

Copy link
Contributor Author

@bmasta018 bmasta018 Dec 11, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated the description in latest patch

lumag
lumag requested changes Dec 9, 2025
View reviewed changes
dynamic-layers/openembedded-layer/recipes-support/sensors/qcom-sensors-binaries_1.0.1.bb Outdated
DESCRIPTION = "Prebuilt libraries and test applications for sensors services"
LICENSE = "LICENSE.qcom-2"
LIC_FILES_CHKSUM = "file://${UNPACKDIR}/usr/share/doc/sensors/NO.LOGIN.BINARY.LICENSE.QTI.pdf;md5=7a5da794b857d786888bbf2b7b7529c8"
SRC_URI = "https://qartifactory-edge.qualcomm.com/artifactory/qsc_releases/software/chip/component/sensors.lnx.0.0/${PBT_BUILD_DATE}/prebuilt_yocto/qcom-sensors-prebuilts_${PV}_armv8a.tar.gz"
Copy link
Contributor

@lumag lumag Dec 9, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why? I think it makes sense. I usually ask to have PBT_BUILD_DATE grouped together with the sha256sum as those two change together.

dynamic-layers/openembedded-layer/recipes-support/sensors/qcom-sensors-binaries_1.0.1.bb Outdated
ln -sf libSEESalt.so.${PV} ${D}${libdir}/libSEESalt.so.0
ln -sf libSEESalt.so.${PV} ${D}${libdir}/libSEESalt.so

# Install proto , registry and Service files
Copy link
Contributor

@lumag lumag Dec 9, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Registry would be a part of the per-device data, so it probably should go to hexagon-dsp-binaries.

Copy link
Contributor Author

@bmasta018 bmasta018 Dec 11, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As we understand it, hexagon-dsp-binaries typically contains compiled DSP executables or shared objects built with the Hexagon C/C++ toolchain.
Placing configuration files into hexagon-dsp-binaries requires careful consideration of their final locations on the target filesystem (for example, under /etc/ or /firmware/). In parallel, from a SensingHub firmware perspective, these configuration files are expected to reside at predefined, fixed locations on the target. Changing the paths to these JSON files would break the current expectations in the firmware’s parsing logic and would require corresponding changes in the firmware as well.
we got your point and we will consider this and come back when we open source our HLOS source code in coming days. Considering this as a artifacts and end to end enablement perspective - we feel it should be fine for now withe current status.
Kindly let us know your feedback.

@github-actions
Copy link

github-actions bot commented Dec 9, 2025

Test run workflow

Test jobs for commit 1bfc488

@test-reporting-app
Copy link

test-reporting-app bot commented Dec 9, 2025 •
edited
Loading

Test Results

 14 files  ±0   28 suites  ±0   37m 15s ⏱️ + 1m 37s
 50 tests ±0   50 ✅ ±0  0 💤 ±0  0 ❌ ±0 
304 runs  ±0  304 ✅ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit 1bfc488. ± Comparison against base commit 65bdc36.

♻️ This comment has been updated with latest results.

vkraleti
vkraleti reviewed Dec 9, 2025
View reviewed changes
dynamic-layers/openembedded-layer/recipes-support/sensors/qcom-sensors-binaries_1.0.1.bb Outdated
SUMMARY = "Prebuilt Qualcomm sensors libraries and test applications"
DESCRIPTION = "Prebuilt libraries and test applications for sensors services"
LICENSE = "LICENSE.qcom-2"
LIC_FILES_CHKSUM = "file://${UNPACKDIR}/usr/share/doc/sensors/NO.LOGIN.BINARY.LICENSE.QTI.pdf;md5=7a5da794b857d786888bbf2b7b7529c8"
Copy link
Contributor

@vkraleti vkraleti Dec 9, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please stop using the .pdf file to mention the License. The tarball must include LICENSE.qcom-2 file.

Copy link
Contributor

@vkraleti vkraleti Dec 9, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, the CHANGES file isn't updated, there is no NOTICE eaither.

Copy link
Contributor Author

@bmasta018 bmasta018 Dec 11, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added the LICENSE file in txt format. The changes files and Notice file has also been updated.

@github-actions
Copy link

github-actions bot commented Dec 9, 2025

Test run workflow

Test jobs for commit 1bfc488

@bmasta018
sensors: add recipe for sensors prebuilt binaries
4f38376 
Prebuilt core binaries required for sensor enablement and
hardware sensor data access. These prebuilt binaries also
Includes test applications to validate sensor services
functionality through the Sensinghub Interface.

Signed-off-by: Bhanu Vivek Matsa <[email protected]>
@bmasta018 bmasta018 force-pushed the sensors-prebuilts-enablement branch from 1bfc488 to 4f38376 Compare December 11, 2025 12:46
lumag
lumag requested changes Dec 11, 2025
View reviewed changes
dynamic-layers/openembedded-layer/recipes-support/sensors/qcom-sensors-binaries_1.0.2.bb
@@ -0,0 +1,55 @@
SUMMARY = "Prebuilt Qualcomm sensors libraries and test applications"
DESCRIPTION = "Prebuilt core binaries required for sensor enablement and hardware sensor data access. These prebuilt binaries also Includes test applications to validate sensor services functionality through the Sensinghub Interface."
Copy link
Contributor

@lumag lumag Dec 11, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

s/Includes/include

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lumag lumag lumag requested changes

@ricardosalveti ricardosalveti ricardosalveti left review comments

@vkraleti vkraleti vkraleti left review comments

@koenkooi koenkooi koenkooi requested changes

@sbanerjee-quic sbanerjee-quic Awaiting requested review from sbanerjee-quic sbanerjee-quic is a code owner

@ndechesne ndechesne Awaiting requested review from ndechesne ndechesne is a code owner

Requested changes must be addressed to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@bmasta018 @lumag @koenkooi @ricardosalveti @vkraleti