packagegroup-*: make ${PN}-hexagon-dsp-binaries RDEPEND on DSP packages #1302
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lumag
requested review from
ndechesne,
ricardosalveti,
sbanerjee-quic and
vkraleti
as code owners
koenkooi
previously approved these changes
Dec 10, 2025
Contributor
koenkooi
left a comment
koenkooi
left a comment
There was a problem hiding this comment.
Fundamentally, RDEPENDS is a better fit since it won't function without these, as RRECOMMENDS implies that it would work.
vkraleti
previously approved these changes
Dec 10, 2025
If the user didn't provide dspso.bin for repacking, OE will skip generating (empty) packages. This limits our ability to always DEPEND on them. Currently it's not an issue, since packagegroups use RRECOMMENDS to pull in DSP packages. Generate empty packages in order to be able to fulfill dependencies when we switch to RDEPEND. Signed-off-by: Dmitry Baryshkov <[email protected]>
Historically we have been using RRECOMMENDS for ${PN}-firmware
packagegroup so that selection of the firmware packages can be
hand-tuned (which is extremely useful for firmware initramfs images).
For Hexagon DSP packagegroups we don't need such a hand-tuning
(if the binaries are being pulled in, the image can handle few extra MB
in the rootfs). On the other hand havign RRECOMMENDS here can leave the
image without DSP binaries: if there is a version mismatch between
linux-firmware and hexagon-dsp-binaries, the binaries will be silently
left out of the rootfs.
Change RRECOMMENDS to RDEPENDS in order ot make sure that DSP binaries
are always actually pulled into the rootfs if the image requires
installation of the ${PN}-hexagon-dsp-binaries.
Signed-off-by: Dmitry Baryshkov <[email protected]>
lumag
force-pushed
the
require-hexagon
branch
from
8bb4fa5 to
9aa0455
Compare
Test run workflowTest jobs for commit 9aa0455
|
Test Results 14 files + 3 28 suites +7 37m 34s ⏱️ + 11m 59s Results for commit 9aa0455. ± Comparison against base commit 7577fc8. This pull request removes 2 and adds 5 tests. Note that renamed tests count towards both.♻️ This comment has been updated with latest results. |
Test run workflowTest jobs for commit 9aa0455
|
koenkooi
approved these changes
Dec 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Historically we have been using RRECOMMENDS for ${PN}-firmware packagegroup so that selection of the firmware packages can be hand-tuned (which is extremely useful for firmware initramfs images).
For Hexagon DSP packagegroups we don't need such a hand-tuning (if the binaries are being pulled in, the image can handle few extra MB in the rootfs). On the other hand havign RRECOMMENDS here can leave the image without DSP binaries: if there is a version mismatch between linux-firmware and hexagon-dsp-binaries, the binaries will be silently left out of the rootfs.
Change RRECOMMENDS to RDEPENDS in order ot make sure that DSP binaries are always actually pulled into the rootfs if the image requires installation of the ${PN}-hexagon-dsp-binaries.