Do not use sudo FQDN lookups #199

basak-qcom · 2025-11-14T16:37:57Z

Details are in the individual commit messages.

basak-qcom · 2025-11-14T16:42:41Z

Author: Robie Basak <[email protected]>
Date:   Fri Nov 14 14:28:01 2025 +0000

    ci: add and integrate qemu_guest_test.py
    
    This allows us to write tests that run natively on the guest, and
    qemu_test.py will invoke them using qemu.
    
    Signed-off-by: Robie Basak <[email protected]>
---
 ci/qemu_guest_test.py | 22 ++++++++++++++++++++++
 ci/qemu_test.py       | 51 ++++++++++++++++++++++++++++++++++++++++++++++++++-
 pyproject.toml        |  7 +++++++
 3 files changed, 79 insertions(+), 1 deletion(-)

80 lines :-)

github-actions · 2025-11-14T17:46:27Z

Test Results

2 files ±0 6 suites ±0 7m 30s ⏱️ ±0s
20 tests ±0 20 ✅ ±0 0 💤 ±0 0 ❌ ±0
64 runs ±0 64 ✅ ±0 0 💤 ±0 0 ❌ ±0

Results for commit deddc35. ± Comparison against base commit 4ec72e8.

♻️ This comment has been updated with latest results.

github-actions · 2025-11-14T17:46:28Z

Test jobs for commit `16bae24`

lool · 2025-11-15T11:16:14Z

Author: Robie Basak <[email protected]>
Date:   Fri Nov 14 14:28:01 2025 +0000

    ci: add and integrate qemu_guest_test.py
    
    This allows us to write tests that run natively on the guest, and
    qemu_test.py will invoke them using qemu.
    
    Signed-off-by: Robie Basak <[email protected]>
---
 ci/qemu_guest_test.py | 22 ++++++++++++++++++++++
 ci/qemu_test.py       | 51 ++++++++++++++++++++++++++++++++++++++++++++++++++-
 pyproject.toml        |  7 +++++++
 3 files changed, 79 insertions(+), 1 deletion(-)

80 lines :-)

basak-qcom · 2025-11-17T09:05:19Z

Presumably that's for the entire PR, which also adds actual guest tests and some other bits (see individual commits)? I'm picking out only the mechanism to implement qemu guest tests itself in my <100 line claim.

In a future change I want to pass around another value as well as the pexpect.spawn object, so make the fixture return a SimpleNamespace that has the spawn object under that instead of it being the direct value. Change the existing test accordingly. This should result in no functional change to the test suite. Signed-off-by: Robie Basak <[email protected]>

Since qemu booting is slow and we want fast developer iteration, we make the optimisation compromise that we will not reset the qemu vm test fixture from a fresh image for every test. Most tests should not collide with each other. If we think a new test will do that and we want to make the compromise of giving it an isolated environment for a slower test suite, we can deal with that then. Signed-off-by: Robie Basak <[email protected]>

This allows us to write tests that run natively on the guest, and qemu_test.py will invoke them using qemu. Signed-off-by: Robie Basak <[email protected]>

If DNS is misconfigured in the deployment environment, sudo may hang while it times out on DNS requests, which is not desirable for the majority of our users. Add a test that identifies if sudo is using DNS. See: qualcomm-linux#193 There isn't an easy and obvious method of testing "did sudo use DNS" that (ideally) is independent of the DNS configuration in the test environment. This is hopefully unintrusive and reasonably flexible. The catch is that if we use sudo-rs in the future then it might stop working if Rust doesn't use libc. But this seems better than nothing. To make it easier to ensure that this test is correctly testing what we need, I've separated the test from the fix using xfail. This way, before the issue is fixed, the test suite passing means that the test is correctly detecting the issue. I'll then introduce the fix in the next change. Signed-off-by: Robie Basak <[email protected]>

Fixes: qualcomm-linux#193 Signed-off-by: Robie Basak <[email protected]>

github-actions · 2025-11-21T13:39:56Z

Test jobs for commit `deddc35`

lool

So I have some doubts about the architecture of this approach:

using expect was necessary for the login interaction, but seems generally brittle and to be avoided; I guess that's only for the bootstraping phase
the dependencies on downloading packages and changing the rootfs are kind of heavy
I would personally prefer if the tests were driven from the host towards the DUT rather than installing an on device framework and I'm not a big fan of the gdb usage here, but there's a limit to what we can do there; in this case, I guess we could set the DNS and check if there are packets coming its way, this would also work with sudo-rs

Anyway, if this works, it is understandable enough that I feel I could debug it if needed and the python and testing code is clean; I've left a few comments to your discretion :)

lool · 2025-11-21T18:43:29Z

ci/qemu_test.py

 def vm():
    """A pexpect.spawn object attached to the serial console of a VM freshly
    booting with a CoW base of disk-ufs.img"""
+    # Since qemu booting is slow and we want fast developer iteration, we make the


should that comment be a couple of lines higher, near the scope definition for the fixture?

lool · 2025-11-21T18:49:53Z

ci/qemu_test.py

+    # We use apt-get -U here and the apt_dependencies fixture in
+    # qemu_guest_test.py relies on this.
+    SCRIPT = f"""sudo -i sh <<EOT
+apt-get install -Uy --no-install-recommends python3-pytest


It's quite unfortunate to introduce a network dependency :-(

I also don't like that we're changing the rootfs, but I guess we need to bring the tests somehow.

Should we just add this test runner to the image?

lool · 2025-11-21T18:55:47Z

ci/qemu_guest_test.py

+                "-x",
+                gdb_commands_file.name,
+                "--args",
+                "sudo",


I'm a little bit surprized that this works; isn't sudo SUID and losing its SUID bit when run under GDB? I guess all tests run as root and this is sudo without SUID launched from the tests launched from a sudo shell.

lool · 2025-11-21T18:56:22Z

ci/qemu_test.py

+mkdir qcom-deb-images
+mount -t 9p qcom-deb-images qcom-deb-images
+cd qcom-deb-images
+py.test-3 -vvm guest ci/qemu_guest_test.py && echo "{SUCCESS_NOTICE}" || echo "{FAILURE_NOTICE}"


Hmm tests running as root; I guess we can revisit this when we need a non-root test

basak-qcom force-pushed the sudo-fqdn branch from dc15c88 to 16bae24 Compare November 14, 2025 16:41

basak-qcom added 5 commits November 21, 2025 12:36

ci: add and integrate qemu_guest_test.py

8ec93a6

This allows us to write tests that run natively on the guest, and qemu_test.py will invoke them using qemu. Signed-off-by: Robie Basak <[email protected]>

Do not use sudo FQDN lookups

deddc35

Fixes: qualcomm-linux#193 Signed-off-by: Robie Basak <[email protected]>

basak-qcom force-pushed the sudo-fqdn branch from 16bae24 to deddc35 Compare November 21, 2025 12:39

basak-qcom marked this pull request as ready for review November 21, 2025 13:14

lool approved these changes Nov 21, 2025

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Do not use sudo FQDN lookups #199

Do not use sudo FQDN lookups #199

Uh oh!

basak-qcom commented Nov 14, 2025

Uh oh!

basak-qcom commented Nov 14, 2025

Uh oh!

github-actions bot commented Nov 14, 2025 •

edited

Loading

Uh oh!

github-actions bot commented Nov 14, 2025

Uh oh!

lool commented Nov 15, 2025

Uh oh!

basak-qcom commented Nov 17, 2025 •

edited

Loading

Uh oh!

github-actions bot commented Nov 21, 2025

Uh oh!

lool left a comment

Uh oh!

lool Nov 21, 2025

Uh oh!

lool Nov 21, 2025

Uh oh!

lool Nov 21, 2025

Uh oh!

lool Nov 21, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Do not use sudo FQDN lookups #199

Are you sure you want to change the base?

Do not use sudo FQDN lookups #199

Uh oh!

Conversation

basak-qcom commented Nov 14, 2025

Uh oh!

basak-qcom commented Nov 14, 2025

Uh oh!

github-actions bot commented Nov 14, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Test Results

Uh oh!

github-actions bot commented Nov 14, 2025

Test jobs for commit 16bae24

Uh oh!

lool commented Nov 15, 2025

Uh oh!

basak-qcom commented Nov 17, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Nov 21, 2025

Test jobs for commit deddc35

Uh oh!

lool left a comment

Choose a reason for hiding this comment

Uh oh!

lool Nov 21, 2025

Choose a reason for hiding this comment

Uh oh!

lool Nov 21, 2025

Choose a reason for hiding this comment

Uh oh!

lool Nov 21, 2025

Choose a reason for hiding this comment

Uh oh!

lool Nov 21, 2025

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

github-actions bot commented Nov 14, 2025 •

edited

Loading

Test jobs for commit `16bae24`

basak-qcom commented Nov 17, 2025 •

edited

Loading

Test jobs for commit `deddc35`