Skip to content

⚡️ Speed up function get_annual_indicator_names by 33% #14

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
misrasaurabh1 wants to merge 4 commits into
base: main
Choose a base branch
from
Open

⚡️ Speed up function get_annual_indicator_names by 33% #14

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
3e155b8
Optimize get_annual_indicator_names
codeflash-ai[bot] Oct 10, 2025
cb5b30f
Apply suggestion from @misrasaurabh1
misrasaurabh1 Oct 16, 2025
090e3f5
Apply suggestion from @misrasaurabh1
misrasaurabh1 Oct 16, 2025
cef3e6d
Apply suggestion from @misrasaurabh1
misrasaurabh1 Oct 16, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions qnt/data/secgov_fundamental.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -500,11 +500,14 @@ def get_standard_indicator_names():


def get_annual_indicator_names():
annual_indicator_names = []
global_annual_us_gaaps_set = set(GLOBAL_ANNUAL_US_GAAPS)

annual_indicator_names = []
for indicator_name, indicator_data in GLOBAL_INDICATORS.items():
facts = indicator_data.get('facts', [])
if all(fact in GLOBAL_ANNUAL_US_GAAPS for fact in facts):
if not facts:
annual_indicator_names.append(indicator_name)
elif set(facts).issubset(global_annual_us_gaaps_set):
annual_indicator_names.append(indicator_name)

return annual_indicator_names
Expand Down