fix(tests): skip integration tests when credentials are missing#62
Open
quanticsoul4772 wants to merge 1 commit intomainfrom
Open
fix(tests): skip integration tests when credentials are missing#62quanticsoul4772 wants to merge 1 commit intomainfrom
quanticsoul4772 wants to merge 1 commit intomainfrom
Conversation
checkRequiredEnv() and checkNeo4jConnectivity() called t.Fatal() when VOYAGE_API_KEY, ANTHROPIC_API_KEY, or Neo4j env vars were absent. This caused all benchmark integration tests to FAIL in CI environments that don't have those secrets configured, even though the logic under test requires no live services. Change t.Fatal/t.Fatalf → t.Skip/t.Skipf throughout both helpers so that the test run reports SKIP rather than FAIL when credentials are unavailable. When the secrets ARE present the tests run exactly as before. This unblocks the CI Test job for Dependabot/merge-queue PRs that have been failing since at least 2026-03-02 due to missing VOYAGE_API_KEY. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Contributor
Benchmark Results |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The `Test (1.24.x)` CI job has been failing since at least 2026-03-02 on every Dependabot PR. Root cause: `checkRequiredEnv()` and `checkNeo4jConnectivity()` call `t.Fatal()` when `VOYAGE_API_KEY`, `ANTHROPIC_API_KEY`, or Neo4j env vars are not set.
Fix
Changed `t.Fatal`/`t.Fatalf` → `t.Skip`/`t.Skipf` in both helpers. When credentials are absent tests report SKIP instead of FAIL — unblocking CI for PRs that don't carry secrets. Behaviour is identical when credentials are present.
Affected tests (all now skip cleanly without creds)
TestMCPClientStartStop, TestMCPClientThinkTool, TestMCPExecutorE2E, TestMCPVsDirectPerformance, TestMCPExecutorServerCrash, TestMCPExecutorConnectionReuse, TestMCPConcurrentCalls, TestMCPProtocolMismatch, TestMCPExecutorTimeout, TestMCPExecutorInvalidResponse
Test plan
🤖 Generated with Claude Code