Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase stale issue time & enhance stale bot config #6924

Merged
merged 6 commits into from
Jan 7, 2025

Conversation

mhucka
Copy link
Contributor

@mhucka mhucka commented Jan 6, 2025

Until we have time to revisit the auto-closing policy (issue #6866), we decided we could increase the duration before issues and PRs are marked as stale and closed. This PR changes the durations to 90 days before marking as stale and 60 days before closing. It also adds a couple of enhancements:

  • Revised and hopefully somewhat friendlier messages left as comments
  • The addition of a manual run trigger, to allow manual invocation and dry runs

mhucka added 3 commits January 6, 2025 13:35
This adjusts the durations before issues and PRs are considered stale,
and also before they're closed.
@CirqBot CirqBot added the size: S 10< lines changed <50 label Jan 6, 2025
@mhucka mhucka added kind/task A task that's part of a larger effort area/best-practices and removed size: S 10< lines changed <50 labels Jan 6, 2025
@CirqBot CirqBot added the size: S 10< lines changed <50 label Jan 6, 2025
@mhucka mhucka self-assigned this Jan 6, 2025
Copy link

codecov bot commented Jan 6, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.86%. Comparing base (83a8e0e) to head (0817f49).
Report is 4 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #6924   +/-   ##
=======================================
  Coverage   97.86%   97.86%           
=======================================
  Files        1084     1084           
  Lines       94290    94299    +9     
=======================================
+ Hits        92280    92289    +9     
  Misses       2010     2010           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mhucka mhucka marked this pull request as ready for review January 6, 2025 22:32
@mhucka mhucka requested review from vtomole and a team as code owners January 6, 2025 22:32
Copy link
Collaborator

@pavoljuhas pavoljuhas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but please confirm the cron-started workflow is run as non-debug.

Comment on lines +10 to +11
type: boolean
default: true
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IIUC, the debug mode is not in effect when this get started on cron schedule, can you please confirm?

Copy link
Contributor Author

@mhucka mhucka Jan 6, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's right; that setting around lines 10-11 is only for when the workflow is invoked manually, via workflow_dispatch. Otherwise, on cron schedule, the value of inputs.debug is never set and is therefore an empty string. In the workflow body, the debug-only flag for actions/stale defaults to false:

debug-only: ${{inputs.debug || false}}

My thinking is that it's rare for someone to want to invoke it manually, and when they do, it's mostly likely because they're debugging something, so the natural default in that case is to turn it on. Plus, it has the advantage of erring on the side of caution, by requiring confirmation for taking action.

Comment on lines +21 to +22
days-before-stale: 90
days-before-close: 60
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should flip these. The issue / PR should become stale before closed.
NVM - after reading how those values work, sorry about the noise.

mhucka added 2 commits January 7, 2025 07:12
Without a name, the name shown in the GitHub UI for workflow execution
is "stale", which is uninformative and ambiguous.
@mhucka mhucka changed the title Increase time stale issue time & enhance config a tiny bit Increase stale issue time & enhance stale bot config Jan 7, 2025
@mhucka mhucka enabled auto-merge (squash) January 7, 2025 19:46
@mhucka mhucka merged commit 488bff4 into main Jan 7, 2025
40 checks passed
@pavoljuhas pavoljuhas deleted the mhucka-increase-stale-duration branch January 22, 2025 07:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/best-practices kind/task A task that's part of a larger effort size: S 10< lines changed <50
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants