Skip to content

Fix #929 by updating Eigen to version 3.4.1 #934

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mhucka merged 9 commits into from
Jan 6, 2026
Merged

Fix #929 by updating Eigen to version 3.4.1 #934

Show file tree
Hide file tree
Changes from 6 commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
d6ec5e8
Update version of Eigen to 3.4.1
mhucka Nov 3, 2025
552cd4b
chore: merge branch
mhucka Nov 3, 2025
51e979e
Use name `EIGEN_COMMIT` as is used in file `WORKSPACE`
mhucka Nov 4, 2025
f8b8e59
Merge branch 'main' into mh-update-eigen
mhucka Nov 4, 2025
3f8526a
Merge branch 'main' into mh-update-eigen
mhucka Nov 4, 2025
b17affe
Merge branch 'main' into mh-update-eigen
mhucka Nov 8, 2025
e6caaf5
Merge branch 'main' into mh-update-eigen
mhucka Jan 6, 2026
f7c8cb7
Update to Eigen 3.4.1
mhucka Jan 6, 2026
bb51f2f
Fix sha256 value
mhucka Jan 6, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@
# limitations under the License.

# Version info for the copy of Eigen we will download and build locally.
EIGEN_PREFIX = "3bb6a48d8c171cf20b5f8e48bfb4e424fbd4f79e"
EIGEN_COMMIT = "d71c30c47858effcbd39967097a2d99ee48db464"
EIGEN_URL = "https://gitlab.com/libeigen/eigen/-/archive/"

# Default build targets. Additional may be added conditionally below.
Expand Down Expand Up @@ -178,9 +178,9 @@ check-cuquantum-root-set:

eigen:
-rm -rf eigen
wget $(EIGEN_URL)/$(EIGEN_PREFIX)/eigen-$(EIGEN_PREFIX).tar.gz
tar -xzf eigen-$(EIGEN_PREFIX).tar.gz && mv eigen-$(EIGEN_PREFIX) eigen
rm eigen-$(EIGEN_PREFIX).tar.gz
wget $(EIGEN_URL)/$(EIGEN_COMMIT)/eigen-$(EIGEN_COMMIT).tar.gz
tar -xzf eigen-$(EIGEN_COMMIT).tar.gz && mv eigen-$(EIGEN_COMMIT) eigen
rm eigen-$(EIGEN_COMMIT).tar.gz

.PHONY: clean
clean:
Expand Down
16 changes: 7 additions & 9 deletions WORKSPACE
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,10 +55,8 @@ load("@org_tensorflow//tensorflow:workspace0.bzl", "workspace")

workspace()


EIGEN_COMMIT = "3bb6a48d8c171cf20b5f8e48bfb4e424fbd4f79e"
EIGEN_SHA256 = "eca9847b3fe6249e0234a342b78f73feec07d29f534e914ba5f920f3e09383a3"

EIGEN_COMMIT = "d71c30c47858effcbd39967097a2d99ee48db464" # 3.4.1
EIGEN_SHA256 = "f1d28c2205d015490a685b1e5a171c434da87f757746724de3cb85e69621dec2"

http_archive(
name = "eigen",
Expand All @@ -70,11 +68,11 @@ cc_library(
)
""",
sha256 = EIGEN_SHA256,
strip_prefix = "eigen-{commit}".format(commit = EIGEN_COMMIT),
urls = [
"https://storage.googleapis.com/mirror.tensorflow.org/gitlab.com/libeigen/eigen/-/archive/{commit}/eigen-{commit}.tar.gz".format(commit = EIGEN_COMMIT),
"https://gitlab.com/libeigen/eigen/-/archive/{commit}/eigen-{commit}.tar.gz".format(commit = EIGEN_COMMIT),
],
strip_prefix = "eigen-{commit}".format(commit = EIGEN_COMMIT),
urls = [
"https://storage.googleapis.com/mirror.tensorflow.org/gitlab.com/libeigen/eigen/-/archive/{commit}/eigen-{commit}.tar.gz".format(commit = EIGEN_COMMIT),
"https://gitlab.com/libeigen/eigen/-/archive/{commit}/eigen-{commit}.tar.gz".format(commit = EIGEN_COMMIT),
],
)

load("//third_party/cuquantum:cuquantum_configure.bzl", "cuquantum_configure")
Expand Down
Loading