Skip to content

Conversation

@mhucka
Copy link
Collaborator

@mhucka mhucka commented Dec 30, 2025

This adds checks to the GitHub Actions workflows for the owner being Quantumlib, so that users who fork the repo will not be surprised by the workflows running in their forks.

This adds checks to the GitHub Actions workflows for the owner being
Quantumlib, so that users who fork the repo will not be surprised by the
workflows running in their forks.
@gemini-code-assist
Copy link
Contributor

Note

Gemini is unable to generate a review for this pull request due to the file types involved not being currently supported.

@github-actions github-actions bot added the size: S 10< lines changed <50 label Dec 30, 2025
@mhucka mhucka requested a review from pavoljuhas December 30, 2025 02:17
Copy link
Collaborator

@pavoljuhas pavoljuhas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I feel we should use if: github.repository_owner == 'quantumlib' everywhere for the sake of uniformity in all workflows.

Also when running for the main repo the CI job will know the outcome instantaneously and would not need to wait for a container to spin up and run the true command.

@mhucka
Copy link
Collaborator Author

mhucka commented Jan 6, 2026

I feel we should use if: github.repository_owner == 'quantumlib' everywhere for the sake of uniformity in all workflows.

Also when running for the main repo the CI job will know the outcome instantaneously and would not need to wait for a container to spin up and run the true command.

OK, I'll change it.

Per review discussion, switching to the approach we use in other repos.
@mhucka mhucka requested a review from pavoljuhas January 6, 2026 07:21
@mhucka mhucka enabled auto-merge January 6, 2026 07:21
@mhucka mhucka added this pull request to the merge queue Jan 6, 2026
Merged via the queue into quantumlib:main with commit 40190fb Jan 6, 2026
28 checks passed
@mhucka mhucka deleted the mh-fix-904 branch January 6, 2026 18:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size: S 10< lines changed <50

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants