-
Notifications
You must be signed in to change notification settings - Fork 194
Fix #904: test that repo owner is Quantumlib #968
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This adds checks to the GitHub Actions workflows for the owner being Quantumlib, so that users who fork the repo will not be surprised by the workflows running in their forks.
|
Note Gemini is unable to generate a review for this pull request due to the file types involved not being currently supported. |
pavoljuhas
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I feel we should use if: github.repository_owner == 'quantumlib' everywhere for the sake of uniformity in all workflows.
Also when running for the main repo the CI job will know the outcome instantaneously and would not need to wait for a container to spin up and run the true command.
OK, I'll change it. |
Per review discussion, switching to the approach we use in other repos.
This adds checks to the GitHub Actions workflows for the owner being Quantumlib, so that users who fork the repo will not be surprised by the workflows running in their forks.
This adds checks to the GitHub Actions workflows for the owner being Quantumlib, so that users who fork the repo will not be surprised by the workflows running in their forks.