-
Notifications
You must be signed in to change notification settings - Fork 195
Move setup.py metadata into pyproject.toml, remove dev-requirements.txt, & fix #839
#985
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 6 commits
Commits
Show all changes
37 commits
Select commit
Hold shift + click to select a range
18bffac
Move most metadata from setup.py to pyproject.toml
mhucka 0f7a2b6
Move contents of dev-requirements.txt into pyproject.toml
mhucka 78383e1
Replace references to dev-requirements.txt
mhucka 2c77214
Add more constraints & comments to requirements.txt
mhucka aedd475
More Dockerfile fixes
mhucka c2d1d3a
Remove some changes that belong in a separate PR
mhucka 59c8cb1
Remove a spurious change to reduce the diff noise
mhucka 794c818
Need to install setuptools on Python >= 3.12
mhucka 3b4102a
Fix syntax
mhucka 2a565d1
Need to install Python dev dependencies
mhucka 1363f94
Merge branch 'main' into mh-pyproject
mhucka 80f980e
Add experimental support for cuStateVecEx. (#965)
sergeisakov 6b95f3a
Make use of larger GitHub job runners (#971)
mhucka 567fb25
Add check/pylint (#978)
mhucka 59e15b8
Use GHA "working-directory" instead of cd'ing (#969)
mhucka 2fe8c97
Detect missing cpuinfo package when running test-libs.sh and let the …
mhucka 464a266
In tests/Makefile, send grep output to /dev/null (#988)
mhucka 34ccd4f
Merge differences
mhucka f2bdcc6
Set HOMEBREW_NO_AUTO_UPDATE in CI (#973)
mhucka 22a3eed
Add `.gitattributes` file for project (#974)
mhucka 2037e80
Add configuration for isort to `pyproject.toml` (#987)
mhucka e0d71a4
Fix #929 by updating Eigen to version 3.4.1 (#934)
mhucka 7926ba5
Fix Makefile handling of user CXXFLAGS & also add a DEBUG flag (#990)
mhucka e478fb1
Fix #892: use -msse4 rather than -msse4.1 in Makefiles (#991)
mhucka 8dfe69e
Fix #904: test that repo owner is Quantumlib (#968)
mhucka bd95d86
Add `-mbmi2` flag when `-mavx2` is used in Makefiles (#992)
mhucka 6032880
In `setup.py`, don't limit CMake version test to only Windows (#995)
mhucka 9d25d30
Do pip install requirements & group dev in one command
mhucka 8f66380
Move cmake & pybind from requirements.txt to pyproject.toml
mhucka 238b171
Remove mention of dev-requirements.txt
mhucka 2f9320f
Adjust `Dockerfile`s for changes in requirements scheme
mhucka e2682a9
Don't need update pip after venv creation
mhucka 996f6f9
Remove unnecessary venv activation
mhucka 74e6c58
Rearrange order of commands in Dockerfile
mhucka c01bd6b
Merge branch 'main' into mh-pyproject
mhucka 6da968f
Merge branch 'main' into mh-pyproject
mhucka 6d858e9
Merge branch 'main' into mh-pyproject
mhucka File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,5 +1,4 @@ | ||
| include requirements.txt | ||
| include dev-requirements.txt | ||
| include CMakeLists.txt | ||
|
|
||
| graft pybind_interface | ||
|
|
||
This file was deleted.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,3 +1,17 @@ | ||
| # Installation and run-time dependencies for qsimcirq. This file is read | ||
| # by pyproject.toml. | ||
|
|
||
| absl-py | ||
| cirq-core~=1.0 | ||
| numpy>=1.26.0 | ||
| numpy>=1.26.0,<2.0; python_version < '3.11' | ||
| numpy>=2.0; python_version >= '3.11' | ||
|
|
||
| # These are needed because installing qsimcirq in some environments may require | ||
| # pip to compile Pybind for that specific platform: | ||
| cmake~=3.28.1 | ||
| pybind11[global] | ||
mhucka marked this conversation as resolved.
Outdated
Show resolved
Hide resolved
|
||
|
|
||
| # These are transitive dependencies we need to constrain to avoid unresolvable | ||
| # installation conflicts due to them requiring higher Python versions: | ||
| scipy<1.16; python_version < '3.11' | ||
| contourpy<1.3; python_version < '3.11' | ||
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.