In tests/Makefile, send grep output to /dev/null #988
Merged
+3
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
On systems where there is no /proc/cpuinfo, you get an error message. We don't need to see it; we just need the result of the grep.
pavoljuhas
approved these changes
Jan 5, 2026
Collaborator
pavoljuhas
left a comment
pavoljuhas
left a comment
There was a problem hiding this comment.
If we want to be extra pedantic consider using the -s option instead (seems posix). Keeping it as is is OK too.
Per suggestion by Pavol in the review, using `grep -s` avoids the need to redirect to `/dev/null` altogether.
Collaborator
Author
You're right, and it does work on macOS too. I could have sworn I tried |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On systems where there is no /proc/cpuinfo, you get an error message. We don't need to see it; we just need the result of the grep.