Skip to content

Add -mbmi2 flag when -mavx2 is used in Makefiles #992

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mhucka merged 7 commits into from
Jan 14, 2026
Merged

Add -mbmi2 flag when -mavx2 is used in Makefiles #992

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
cc9805b
Add `-mbmi2` flag when `-mavx2` is used
mhucka Jan 6, 2026
650e4b7
Merge branch 'main' into mh-add-mbmi-flag
mhucka Jan 6, 2026
4de348a
Don't assume bmi2 with avx2
mhucka Jan 9, 2026
e0e0f13
Add test for bmi2 support
mhucka Jan 9, 2026
6a0e6a7
Test support of `-mbmi2` before using it
mhucka Jan 13, 2026
08fa266
Take out -mbmi2 for now
mhucka Jan 13, 2026
293abab
Use a proper test for BMI2
mhucka Jan 14, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion pybind_interface/Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,7 @@ endif
# The flags for the compilation of the simd-specific Pybind11 interfaces
PYBINDFLAGS_BASIC = $(PYBINDFLAGS)
PYBINDFLAGS_SSE = -msse4 $(PYBINDFLAGS)
PYBINDFLAGS_AVX2 = -mavx2 -mfma $(PYBINDFLAGS)
PYBINDFLAGS_AVX2 = -mavx2 -mfma -mbmi2 $(PYBINDFLAGS)
PYBINDFLAGS_AVX512 = -mavx512f -mbmi2 $(PYBINDFLAGS)

# The flags for the compilation of CUDA-specific Pybind11 interfaces
Expand Down
2 changes: 1 addition & 1 deletion pybind_interface/avx2/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ if(WIN32)
# This prevents a conflict with /RTC1 in DEBUG builds.
add_compile_options($<$<NOT:$<CONFIG:Debug>>:/O2>)
else()
add_compile_options(-mavx2 -mfma -O3 -flto=auto)
add_compile_options(-mavx2 -mfma -mbmi2 -O3 -flto=auto)
endif()

if(APPLE)
Expand Down
1 change: 1 addition & 0 deletions tests/BUILD
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,7 @@ load("@rules_cc//cc:defs.bzl", "cc_library", "cc_test")
# Options for testing different simulator types.
avx_copts = [
"-mavx2",
"-mbmi2",
"-mfma",
]

Expand Down
2 changes: 1 addition & 1 deletion tests/Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ ifneq (,$(HAVE_SSE))
SSE_FILES := $(wildcard *_sse_test.cc)
endif
ifneq (,$(HAVE_AVX2))
AVX2_FLAGS ?= -mavx2 -mfma
AVX2_FLAGS ?= -mavx2 -mfma -mbmi2
AVX2_FILES := $(wildcard *_avx_test.cc)
endif
ifneq (,$(HAVE_AVX512))
Expand Down
Loading