Replace Redis Docker image in test classes with a specific version for consistency#534
Open
matheusandre1 wants to merge 1 commit into
Open
Replace Redis Docker image in test classes with a specific version for consistency#534matheusandre1 wants to merge 1 commit into
matheusandre1 wants to merge 1 commit into
Conversation
| private static final Logger LOGGER = LoggerFactory.getLogger(RedisResource.class); | ||
|
|
||
| static final GenericContainer<?> REDIS = new GenericContainer<>(DockerImageName.parse("redis:7")) | ||
| static final GenericContainer<?> REDIS = new GenericContainer<>(DockerImageName.parse("valkey/valkey:7.2-alpine")) |
Member
There was a problem hiding this comment.
Can you add this image name as a system property set by mvn in this module's pom? So that we can upgrade it as part of dependabot checks.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The pull request is related to this: #533 (comment)
Adding testing and fixing the Docker image
Test Plan
Manual Testing
Checklist
Before submitting this PR, please ensure:
./mvnw clean install -DskipITs=false