Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix: IDA mnemonics fallback for architectures not supported by capstone #21

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

dominikbayerl
Copy link
Contributor

quokka.CapstoneErrors are currently not handled appropriately, i.e. if you try to get instruction listings for an architecture not supported by capstone, you receive the error quokka.exc.CapstoneError: Unable to find the Architecture:

try:
capstone_arch, capstone_mode = mapping.get(arch)
except TypeError as exc:
raise quokka.CapstoneError("Unable to find the Architecture") from exc

This patch addresses this, by handling quokka.CapstoneError with a proper fallback to the IDA disassembly, at least for instruction mnemonics.

…ted by capstone.

quokka.CapstoneErrors are currently not handled appropriately, i.e. if you try to get
instruction listings for an architecture not supported by capstone, you receive the
error `quokka.exc.CapstoneError: Unable to find the Architecture`.

This patch addresses this, by handling quokka.CapstoneError with a proper fallback
to the IDA disassembly.

Signed-off-by: Dominik Bayerl <[email protected]>
@dominikbayerl
Copy link
Contributor Author

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant