Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tweak and optimize vale config #30397

Merged
merged 1 commit into from
Jan 17, 2023

Conversation

michelle-purcell
Copy link
Contributor

@michelle-purcell michelle-purcell commented Jan 16, 2023

Fixes some issues that were identified in PR #30378

  • In PR build: have vale lint only run on affected files #30378, test text was added to trigger vale with new config. In the PR, Vale flagged 'gradle' and 'yaml' as being in wrong case ✔️ AND bad spelling ❌ .

    • With this tweak 'yaml' and 'gradle' are flagged as case issues only, reducing Vale diff churn.
  • The PR highlighted that some of the vale.ini config was un-necessary.

    • With this tweak, the vale.ini contains only the required Vale config for analyzing AsciiDoc (*.adoc) format doc source files.

cc @maxandersen

@quarkus-bot
Copy link

quarkus-bot bot commented Jan 16, 2023

✔️ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

Copy link
Contributor

@maxandersen maxandersen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great.

@geoand geoand merged commit 5146f8a into quarkusio:main Jan 17, 2023
@quarkus-bot quarkus-bot bot added this to the 2.17 - main milestone Jan 17, 2023
@michelle-purcell michelle-purcell deleted the tweak-vale-config branch May 8, 2023 08:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants