Added class name check to remove warning #50722

Aryant-Tripathi · 2025-10-25T17:13:43Z

Added class name check to remove warning that package cannot be indexed due to package-info.java
Closes: HibernateOrmProcessor causes Warning that package cannot be indexed due to package-info.java #50572

[Please describe here what your change is about]

…xed due to package-info.java - Closes: quarkusio#50572

quarkus-bot · 2025-10-25T17:14:07Z

/cc @gsmet (hibernate-orm)

mbellade

Thank you @Aryant-Tripathi, this is a good start. I've left a few comments to start with, but I wanted to remind you we need a non-regression test that ideally would verify no warning is thrown for any package-info.java found in the index while still generating proxy classes for all entities correctly.

mbellade · 2025-10-27T08:01:12Z

...-orm/deployment/src/main/java/io/quarkus/hibernate/orm/deployment/HibernateOrmProcessor.java

        for (AdditionalJpaModelBuildItem additionalJpaModelBuildItem : additionalJpaModelBuildItems) {
            managedClassAndPackageNames.add(additionalJpaModelBuildItem.getClassName());
        }

-        PreGeneratedProxies proxyDefinitions = generateProxies(managedClassAndPackageNames,
+        PreGeneratedProxies proxyDefinitions = generateProxies(managedClassAndPackageNames, managedClassesName,


We'll need to add the additionalJpaModelBuildItems class-names as well, otherwise we'll fail to generate proxies for any entity class contained there.

...-orm/deployment/src/main/java/io/quarkus/hibernate/orm/deployment/HibernateOrmProcessor.java

mbellade · 2025-10-27T08:04:16Z

...-orm/deployment/src/main/java/io/quarkus/hibernate/orm/deployment/HibernateOrmProcessor.java

+
+            if(!jpaModel.getEntityClassNames().contains(modelClassName)) {
+                // We only care about class name here
+                continue;
+            }
+


I don't think this is correct, as you can see within this for loop we add the modelClassName to the model.allModelClassAndPackageNames() on line 1257 even if it's not an entity.

Yeah, unfortunately this patch is too simple and would cause trouble down the way.

Really, you can't use existing information in jpaModel, you need to create a separate Set @Aryant-Tripathi.

See the explanation I gave in this comment: #50572 (comment)

Sorry but this is still not enough. I added a comment further up in this file, hopefully this will clear things up...

If you think my comment does not make sense, please say so, so we can discuss that. don't just ignore it :)

yrodiere · 2025-10-27T08:27:39Z

...-orm/deployment/src/main/java/io/quarkus/hibernate/orm/deployment/HibernateOrmProcessor.java

+
+            if(!jpaModel.getEntityClassNames().contains(modelClassName)) {
+                // We only care about class name here
+                continue;
+            }
+


Yeah, unfortunately this patch is too simple and would cause trouble down the way.

Really, you can't use existing information in jpaModel, you need to create a separate Set @Aryant-Tripathi.

See the explanation I gave in this comment: #50572 (comment)

- Added Package info non regression test for verfying the index warning

...-orm/deployment/src/main/java/io/quarkus/hibernate/orm/deployment/HibernateOrmProcessor.java

yrodiere · 2025-10-28T08:46:30Z

...-orm/deployment/src/main/java/io/quarkus/hibernate/orm/deployment/HibernateOrmProcessor.java

            // is used for packages too, and it relies (indirectly) on getManagedClassNames().
            managedClassAndPackageNames.addAll(pud.getManagedClassNames());
        }



You also need to update the for loop above, to have an equivalent of managedClassAndPackageNames.addAll(pud.getManagedClassNames()); but for the managedClassesName set.

Now, obviously you cannot use pud.getManagedClassNames() for that, because that thing also returns package names. Which is where my comment should start to make sense: #50572 (comment)

I then believe sir, we have to add one more data member inside QuarkusPersistenceUnitDescriptor class, which only contains the classes name. We can take use of that data member in creating set of only managed class name.

If it seems ok, may I proceed with those changes ?

Yes this seems perfectly reasonable :)

yrodiere · 2025-10-28T08:47:52Z

...-orm/deployment/src/main/java/io/quarkus/hibernate/orm/deployment/HibernateOrmProcessor.java

+
+            if(!jpaModel.getEntityClassNames().contains(modelClassName)) {
+                // We only care about class name here
+                continue;
+            }
+


Sorry but this is still not enough. I added a comment further up in this file, hopefully this will clear things up...

If you think my comment does not make sense, please say so, so we can discuss that. don't just ignore it :)

…ed due to package-info. Closes: quarkusio#50572

yrodiere · 2025-10-30T14:11:49Z

...me/src/main/java/io/quarkus/hibernate/orm/runtime/boot/QuarkusPersistenceUnitDescriptor.java

+    public List<String> getManagedClassAndPackagesNames() {
+        return managedClassAndPackagesNames;
+    }
+
    @Override
    public List<String> getManagedClassNames() {


Unfortunately you cannot do that. getManagedClassNames() is inherited, it's something from Hibernate ORM and it's really is intended to hold both class names and package names. See org.hibernate.jpa.boot.spi.PersistenceUnitDescriptor.

So, you need to make sure getManagedClassNames() will continue to return both class names and package names.

The method you'll add will need to be the one that only returns class names, for example you could name it getManagedClassNamesOnly().

yrodiere · 2025-10-30T14:12:18Z

...me/src/main/java/io/quarkus/hibernate/orm/runtime/boot/QuarkusPersistenceUnitDescriptor.java

+    @Override
+    public ClassTransformer getClassTransformer() {
+        // We transform classes during the build, not on bootstrap.
+        return null;
+    }
+
    @Override
    public String toString() {
        return "QuarkusPersistenceUnitDescriptor{" +
                "name='" + name + '\'' +
+                ", providerHelper=" + providerHelper +
                ", providerClassName='" + providerClassName + '\'' +
                ", useQuotedIdentifiers=" + useQuotedIdentifiers +
-                ", transactionType=" + persistenceUnitTransactionType +
+                ", persistenceUnitTransactionType=" + persistenceUnitTransactionType +
                ", validationMode=" + validationMode +
                ", sharedCacheMode=" + sharedCacheMode +
+                ", managedClassAndPackagesNames=" + managedClassAndPackagesNames +
                ", managedClassNames=" + managedClassNames +
                ", properties=" + properties +
-                ", isReactive=" + reactive +
+                ", reactive=" + reactive +
                '}';
    }
-
-    @Override
-    public ClassTransformer getClassTransformer() {
-        // We transform classes during the build, not on bootstrap.
-        return null;
-    }


These changes seem unnecessary. Please drop them?

yrodiere · 2025-10-30T14:13:59Z

...-orm/deployment/src/main/java/io/quarkus/hibernate/orm/deployment/HibernateOrmProcessor.java

+                    if (!managedClassesName.contains(managedClassOrPackageName)) {
+                        // we don't generate proxies for packages:
+                        continue;
+                    }


You could simply iterate on managedClassesName instead of iterating on managedClassAndPackageNames?

yrodiere · 2025-10-30T14:18:51Z

...-orm/deployment/src/main/java/io/quarkus/hibernate/orm/deployment/HibernateOrmProcessor.java


-                        if (jpaModel.getEntityClassNames().contains(modelClassName)) {
+                        if (managedClassNames.contains(modelClassName)) {
                            model.entityClassNames().add(modelClassName);


This is incorrect and should be reverted.

yrodiere · 2025-10-30T14:19:35Z

...me/src/main/java/io/quarkus/hibernate/orm/runtime/boot/QuarkusPersistenceUnitDescriptor.java

    public QuarkusPersistenceUnitDescriptor(String name,
            QuarkusPersistenceUnitProviderHelper providerHelper,
            PersistenceUnitTransactionType persistenceUnitTransactionType,
-            List<String> managedClassNames,
+            List<String> managedClassAndPackagesNames, List<String> managedClassNames,
            Properties properties, boolean reactive) {


I believe you did not update calls to this constructor in HibernateOrmProcessor, so it likely doesn't compile anymore. Please try to compile locally before pushing :)

yrodiere · 2025-10-30T14:23:46Z

...yment/src/main/java/io/quarkus/hibernate/reactive/deployment/HibernateReactiveProcessor.java

                new HibernateReactivePersistenceUnitProviderHelper(),
                PersistenceUnitTransactionType.RESOURCE_LOCAL,
                new ArrayList<>(model == null ? Collections.emptySet() : model.allModelClassAndPackageNames()),
+                new ArrayList<>(model == null ? Collections.emptySet() : model.entityClassNames()),


This is incorrect. We want all model classes here.

Entity classes =~ classes annontated with @entity

Managed classes =~ entity classes + classes annontated with @MappedSuperclass or @embeddable

All model classes =~ managed classes + some additional model types used in entity attributes, possibly enums, etc.

You need something like:

Suggested change

new ArrayList<>(model == null ? Collections.emptySet() : model.entityClassNames()),

new ArrayList<>(model == null ? Collections.emptySet() : model.allModelClassNames()),

And that requires adding data to JpaPersistenceUnitModel, and to anything that contributes to it.

Again, you will have an easier time if you read my comment and have a look at the parts of the code I pointed out: #50572 (comment)

- fixes quarkusio#50618 Co-authored-by: George Gastaldi <[email protected]>

Bumps [io.quarkus.gizmo:gizmo2](https://github.com/quarkusio/gizmo) from 2.0.0.Beta6 to 2.0.0.Beta8. - [Release notes](https://github.com/quarkusio/gizmo/releases) - [Commits](quarkusio/gizmo@2.0.0.Beta6...2.0.0.Beta8) --- updated-dependencies: - dependency-name: io.quarkus.gizmo:gizmo2 dependency-version: 2.0.0.Beta8 dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]>

Bumps [com.google.errorprone:error_prone_annotations](https://github.com/google/error-prone) from 2.42.0 to 2.43.0. - [Release notes](https://github.com/google/error-prone/releases) - [Commits](google/error-prone@v2.42.0...v2.43.0) --- updated-dependencies: - dependency-name: com.google.errorprone:error_prone_annotations dependency-version: 2.43.0 dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]>

In all these wiring classes, we can do without parameters or debug info. Gizmo 1 weren't adding parameters and debug info so we are on par with what we used to do with Gizmo 1.

Allow JUnit5 to create the instance Signed-off-by: Michael Edgar <[email protected]>

Fixes: quarkusio#50617

…me name

Bumps `flyway.version` from 11.14.1 to 11.15.0. Updates `org.flywaydb:flyway-core` from 11.14.1 to 11.15.0 - [Release notes](https://github.com/flyway/flyway/releases) - [Commits](flyway/flyway@flyway-11.14.1...flyway-11.15.0) Updates `org.flywaydb:flyway-sqlserver` from 11.14.1 to 11.15.0 Updates `org.flywaydb:flyway-mysql` from 11.14.1 to 11.15.0 Updates `org.flywaydb:flyway-database-oracle` from 11.14.1 to 11.15.0 Updates `org.flywaydb:flyway-database-postgresql` from 11.14.1 to 11.15.0 Updates `org.flywaydb:flyway-database-db2` from 11.14.1 to 11.15.0 Updates `org.flywaydb:flyway-database-derby` from 11.14.1 to 11.15.0 Updates `org.flywaydb:flyway-database-mongodb` from 11.14.1 to 11.15.0 --- updated-dependencies: - dependency-name: org.flywaydb:flyway-core dependency-version: 11.15.0 dependency-type: direct:production update-type: version-update:semver-minor - dependency-name: org.flywaydb:flyway-sqlserver dependency-version: 11.15.0 dependency-type: direct:production update-type: version-update:semver-minor - dependency-name: org.flywaydb:flyway-mysql dependency-version: 11.15.0 dependency-type: direct:production update-type: version-update:semver-minor - dependency-name: org.flywaydb:flyway-database-oracle dependency-version: 11.15.0 dependency-type: direct:production update-type: version-update:semver-minor - dependency-name: org.flywaydb:flyway-database-postgresql dependency-version: 11.15.0 dependency-type: direct:production update-type: version-update:semver-minor - dependency-name: org.flywaydb:flyway-database-db2 dependency-version: 11.15.0 dependency-type: direct:production update-type: version-update:semver-minor - dependency-name: org.flywaydb:flyway-database-derby dependency-version: 11.15.0 dependency-type: direct:production update-type: version-update:semver-minor - dependency-name: org.flywaydb:flyway-database-mongodb dependency-version: 11.15.0 dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]>

Signed-off-by: Phillip Kruger <[email protected]>

This reverts commit 52ba3d5.

Add fallback to use root implementor when no matching handleRequest method is found in the class hierarchy. Closes quarkusio#49413

…rnateormprocessor

- Added class name check to remove warning that pckage cannot be inde…

3c203fb

…xed due to package-info.java - Closes: quarkusio#50572

quarkus-bot bot added the area/hibernate-orm Hibernate ORM label Oct 25, 2025

mbellade reviewed Oct 27, 2025

View reviewed changes

yrodiere changed the title ~~- Added class name check to remove warning~~ Added class name check to remove warning Oct 27, 2025

yrodiere requested changes Oct 27, 2025

View reviewed changes

Fix package info index warning in hibernate orm processor

b833f13

- Added Package info non regression test for verfying the index warning

Aryant-Tripathi requested a review from mbellade October 28, 2025 04:43

yrodiere requested changes Oct 28, 2025

View reviewed changes

Added class name check to remove warning that package cannot be index…

fd68642

…ed due to package-info. Closes: quarkusio#50572

quarkus-bot bot added area/hibernate-search Hibernate Search area/hibernate-reactive Hibernate Reactive labels Oct 29, 2025

yrodiere requested changes Oct 30, 2025

View reviewed changes

mkouba and others added 17 commits November 6, 2025 00:33

Qute generator: fix multiple namespace extension methods

2fe0271

- fixes quarkusio#50618 Co-authored-by: George Gastaldi <[email protected]>

Bypass filters looking for a test class in the application module

e83711e

fix(ws-next): validate base URI scheme

d0925a7

ArC: fix subclass generation with not visible decorators

06ab0bb

ArC: add comments about decorators being interface-based

3023296

Reduce footprint of wiring classes generated by Gizmo 2

0040b6f

In all these wiring classes, we can do without parameters or debug info. Gizmo 1 weren't adding parameters and debug info so we are on par with what we used to do with Gizmo 1.

Intercept dev mode test instance for HTTP resource injection

91756cd

Allow JUnit5 to create the instance Signed-off-by: Michael Edgar <[email protected]>

Ensure that FJP threads can load resources in tests

25201f3

Fixes: quarkusio#50617

Add comment about ForkJoinClassLoading#setForkJoinClassLoader

c7b878e

Hibernate HQL console: fix combo box for reactive/orm PUs with the sa…

573a771

…me name

Jandex: upgrade to 3.5.1

795141c

Dev UI Agroal: add support for json cols

a504778

Signed-off-by: Phillip Kruger <[email protected]>

Reapply "Contain the use of reflection in amazon-lambda"

0d3395e

This reverts commit 52ba3d5.

Fix Amazon Lambda handler discovery fallback

9eb8296

Add fallback to use root implementor when no matching handleRequest method is found in the class hierarchy. Closes quarkusio#49413

Merge branch 'main' into 50572/fix-package-info-index-warning-in-hibe…

fd70b63

…rnateormprocessor

	new ArrayList<>(model == null ? Collections.emptySet() : model.entityClassNames()),
	new ArrayList<>(model == null ? Collections.emptySet() : model.allModelClassNames()),

Added class name check to remove warning #50722

Are you sure you want to change the base?

Added class name check to remove warning #50722

Uh oh!

Conversation

Aryant-Tripathi commented Oct 25, 2025

Uh oh!

quarkus-bot bot commented Oct 25, 2025

Uh oh!

mbellade left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Aryant-Tripathi Oct 28, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

29 participants

Aryant-Tripathi Oct 28, 2025 •

edited

Loading