-
Notifications
You must be signed in to change notification settings - Fork 3k
Bump OpenTelemetry to 1.55.0 #50731
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Bump OpenTelemetry to 1.55.0 #50731
Conversation
|
/cc @radcortez (opentelemetry) |
e8810d7 to
6b320ff
Compare
|
🎊 PR Preview 365da76 has been successfully built and deployed to https://quarkus-pr-main-50731-preview.surge.sh/version/main/guides/
|
536cf9f to
1dc6902
Compare
|
Looks like latest OTel should be ok with Quarkus. CI pending. Please let me know if we can merge this. |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
43aae5a to
ba1fad0
Compare
This comment has been minimized.
This comment has been minimized.
|
Worth adding to the migration guide. Bonus points if a migration yaml is provided in the quarkus-updates repository |
|
Will wait to also upgrade SR Reactive Messaging. smallrye/smallrye-reactive-messaging#3210 |
ba1fad0 to
bcc4ff5
Compare
Status for workflow
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This works with the current Quarkus CXF main and CXF main.
|
@brunobat I think we can merge this as long as we make sure we have a new SR Messaging release before we ship 3.30. Would it be fine with you? |
|
I'm ok if @ozangunalp agrees. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A minor comment for vertx redis tracer
| @Override | ||
| public String getDbNamespace(CommandTrace commandTrace) { | ||
| return DbClientAttributesGetter.super.getDbNamespace(commandTrace); | ||
| return null; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Was this wrong before ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Returning null is odd indeed. If that's what we want to do, maybe a comment would help.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The method was removed...
Effectively, the previous code was returning null.
Null means it will not output that attribute.
|
There will be a reactive messaging 4.31.0 release this week. |

OTel versions to target on this upgrade:
Breaking change:
Not much.
io.opentelemetry.instrumentation.api.incubator.semconv.util.SpanNameswas removed andio.opentelemetry.instrumentation.api.semconv.util.SpanNamesmust be used instead.