Skip to content

Conversation

@brunobat
Copy link
Contributor

@brunobat brunobat commented Oct 27, 2025

OTel versions to target on this upgrade:

  • OTel SDK -> 1.55.0
  • opentelemetry-java-instrumentation -> 2.21.0
  • OTel Java semantic conventions -> 1.37.0
  • opentelemetry-aws-xray-propagator.version>1.51.0-alpha

Breaking change:

Not much.

  • io.opentelemetry.instrumentation.api.incubator.semconv.util.SpanNames was removed and io.opentelemetry.instrumentation.api.semconv.util.SpanNames must be used instead.

@quarkus-bot quarkus-bot bot added area/dependencies Pull requests that update a dependency file area/tracing labels Oct 27, 2025
@quarkus-bot
Copy link

quarkus-bot bot commented Oct 27, 2025

/cc @radcortez (opentelemetry)

@brunobat brunobat force-pushed the bump-otel-1-54-partII branch from e8810d7 to 6b320ff Compare October 27, 2025 11:25
@brunobat brunobat changed the title Bump OpenTelemetry to 1.54 Bump OpenTelemetry to 1.54.1 Oct 27, 2025
@github-actions
Copy link

github-actions bot commented Oct 27, 2025

🎊 PR Preview 365da76 has been successfully built and deployed to https://quarkus-pr-main-50731-preview.surge.sh/version/main/guides/

  • Images of blog posts older than 3 months are not available.
  • Newsletters older than 3 months are not available.

@brunobat brunobat force-pushed the bump-otel-1-54-partII branch 2 times, most recently from 536cf9f to 1dc6902 Compare October 29, 2025 16:31
@brunobat brunobat changed the title Bump OpenTelemetry to 1.54.1 Bump OpenTelemetry to 1.55.0 Oct 29, 2025
@brunobat brunobat marked this pull request as ready for review October 29, 2025 16:32
@brunobat
Copy link
Contributor Author

Looks like latest OTel should be ok with Quarkus. CI pending. Please let me know if we can merge this.
cc @ppalaga, @aureamunoz, @karesti, @mabartos

@quarkus-bot

This comment has been minimized.

@quarkus-bot

This comment has been minimized.

@brunobat brunobat force-pushed the bump-otel-1-54-partII branch 2 times, most recently from 43aae5a to ba1fad0 Compare October 30, 2025 15:08
@quarkus-bot

This comment has been minimized.

@gastaldi
Copy link
Contributor

Worth adding to the migration guide. Bonus points if a migration yaml is provided in the quarkus-updates repository

@brunobat
Copy link
Contributor Author

brunobat commented Oct 31, 2025

Will wait to also upgrade SR Reactive Messaging. smallrye/smallrye-reactive-messaging#3210

@brunobat brunobat force-pushed the bump-otel-1-54-partII branch from ba1fad0 to bcc4ff5 Compare October 31, 2025 10:09
@quarkus-bot
Copy link

quarkus-bot bot commented Oct 31, 2025

Status for workflow Quarkus CI

This is the status report for running Quarkus CI on commit bcc4ff5.

✅ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

You can consult the Develocity build scans.


Flaky tests - Develocity

⚙️ JVM Tests - JDK 21

📦 test-framework/jacoco/runtime

io.quarkus.jacoco.runtime.DataFileWatchTest.waitForDataFileThatNeverAppears - History

  • Expecting value to be false but was true - org.opentest4j.AssertionFailedError
org.opentest4j.AssertionFailedError: 

Expecting value to be false but was true
	at io.quarkus.jacoco.runtime.DataFileWatchTest.waitForDataFileThatNeverAppears(DataFileWatchTest.java:208)
	at java.base/java.lang.reflect.Method.invoke(Method.java:580)
	at java.base/java.util.ArrayList.forEach(ArrayList.java:1596)
	at java.base/java.util.ArrayList.forEach(ArrayList.java:1596)

⚙️ MicroProfile TCKs Tests

📦 tcks/microprofile-lra

org.eclipse.microprofile.lra.tck.TckRecoveryTests.testCancelWhenParticipantIsUnavailable - History

  • Expecting the metric Compensated callback was called Expected: a value equal to or greater than <1> but: <0> was less than <1> - java.lang.AssertionError
java.lang.AssertionError: 
Expecting the metric Compensated callback was called
Expected: a value equal to or greater than <1>
     but: <0> was less than <1>
	at org.hamcrest.MatcherAssert.assertThat(MatcherAssert.java:20)
	at org.eclipse.microprofile.lra.tck.TckRecoveryTests.assertMetricCallbackCalled(TckRecoveryTests.java:210)
	at org.eclipse.microprofile.lra.tck.TckRecoveryTests.testCancelWhenParticipantIsUnavailable(TckRecoveryTests.java:195)
	at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)

Copy link
Contributor

@ppalaga ppalaga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This works with the current Quarkus CXF main and CXF main.

@gsmet
Copy link
Member

gsmet commented Nov 4, 2025

@brunobat I think we can merge this as long as we make sure we have a new SR Messaging release before we ship 3.30. Would it be fine with you?

@brunobat
Copy link
Contributor Author

brunobat commented Nov 4, 2025

I'm ok if @ozangunalp agrees.

Copy link
Contributor

@ozangunalp ozangunalp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A minor comment for vertx redis tracer

@Override
public String getDbNamespace(CommandTrace commandTrace) {
return DbClientAttributesGetter.super.getDbNamespace(commandTrace);
return null;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was this wrong before ?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Returning null is odd indeed. If that's what we want to do, maybe a comment would help.

Copy link
Contributor Author

@brunobat brunobat Nov 5, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The method was removed...
Effectively, the previous code was returning null.
Null means it will not output that attribute.

@ozangunalp
Copy link
Contributor

There will be a reactive messaging 4.31.0 release this week.
But I don't think we need a reactive messaging release for this bump.
On RM it is only a version bump. We did the hard work on the previous release 4.30.0, which is already on the Quarkus main.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/dependencies Pull requests that update a dependency file area/tracing triage/flaky-test

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants