Skip to content

Conversation

@mcruzdev
Copy link
Contributor

@mcruzdev mcruzdev commented Nov 3, 2025

This pull request drops the property quarkus.datasource.jdbc.metrics-enabled that was marked as @Deprecated.

Closes #50607

@quarkus-bot quarkus-bot bot added area/agroal area/docstyle issues related for manual docstyle review area/documentation labels Nov 3, 2025
@quarkus-bot

This comment has been minimized.

@quarkus-bot

This comment has been minimized.

@github-actions
Copy link

github-actions bot commented Nov 3, 2025

🙈 The PR is closed and the preview is expired.

@quarkus-bot

This comment has been minimized.

@quarkus-bot

This comment has been minimized.

@quarkus-bot
Copy link

quarkus-bot bot commented Nov 4, 2025

Status for workflow Quarkus Documentation CI

This is the status report for running Quarkus Documentation CI on commit 83d0784.

✅ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

Warning

There are other workflow runs running, you probably need to wait for their status before merging.

@quarkus-bot
Copy link

quarkus-bot bot commented Nov 4, 2025

Status for workflow Quarkus CI

This is the status report for running Quarkus CI on commit 83d0784.

✅ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

You can consult the Develocity build scans.

@Sanne Sanne requested a review from brunobat November 4, 2025 17:50
@gsmet gsmet requested a review from yrodiere November 5, 2025 08:58
Copy link
Member

@yrodiere yrodiere left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If @gsmet is fine with this, so am I, but shouldn't we at least have one release with both the deprecated property and its replacement, if we want the deprecation to be actionable?

@brunobat
Copy link
Contributor

brunobat commented Nov 5, 2025

@yrodiere the property was already marked as deprecated in May: a9ddc59
Will create a wiki entry for the removal.
The new property was already there and the documentation also refereed to it, but in an incomplete way.

@brunobat brunobat merged commit 840ee21 into quarkusio:main Nov 5, 2025
54 checks passed
@quarkus-bot quarkus-bot bot added this to the 3.30 - main milestone Nov 5, 2025
@quarkus-bot quarkus-bot bot added the kind/enhancement New feature or request label Nov 5, 2025
@brunobat
Copy link
Contributor

brunobat commented Nov 5, 2025

Thanks @mcruzdev !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/agroal area/docstyle issues related for manual docstyle review area/documentation kind/enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

The "quarkus.datasource.jdbc.enable-metrics" config property is deprecated and should not be used anymore

4 participants