Skip to content

Conversation

@QuarkOS
Copy link

@QuarkOS QuarkOS commented Nov 26, 2025

Summary

While reviewing the codebase, I identified and corrected spelling errors across several extensions (Kubernetes, Redis, Qute, OIDC) and independent projects

Changes

  • Class Rename: Renamed ReponseInfoTest to ResponseInfoTest in independent-projects/resteasy-reactive to fix a typo in the class name
  • Log Messages: Fixed "succesfully" -> "successfully" in OidcClientRegistrationImpl and RegisteredClientImpl to improve log searchability
  • Javadocs & Comments: Corrected various typos ("teh", "accross", "seperated") in ImageBuilder, WebSocket, etc
  • Resources: Fixed typos in Grafana dashboard JSON files

Verification

  • these changes are primarily documentation, log messages, and a test class rename
  • verified that the file rename was correctly handled via Git (git status showed renamed:)

Checklist

  • I have read the contributing guide
  • I have analyzed the best way to implement the fix
  • I have tested the changes (verified file status and spelling)

@quarkus-bot quarkus-bot bot added area/core area/devtools Issues/PR related to maven, gradle, platform and cli tooling/plugins area/graphql area/kubernetes area/oidc area/openapi area/platform Issues related to definition and interaction with Quarkus Platform area/qute The template engine area/redis area/smallrye area/testing labels Nov 26, 2025
@QuarkOS QuarkOS changed the title chore: fix typos across multiple modules and rename ReponseInfoTest Fix typos across multiple modules and rename ReponseInfoTest Nov 26, 2025
Copy link
Member

@gsmet gsmet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. The typo fixes looks good but I think we should revert the changes in StartupLogCompressor and squash.

Can you take care of it?

Comment on lines 72 to 74
if (sl != null) {
sl.close();
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think this is needed as it's protected by the thread == null test.

Same for the other fixes in this class.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done. Ive reverted the changes to StartupLogCompressor.java and squashed the commits

Corrected spelling errors in Javadocs, logs, and comments across OIDC, Kubernetes, and Qute extensions. Renamed ReponseInfoTest to ResponseInfoTest to fix class name typo.

Signed-off-by: Quark <[email protected]>
@QuarkOS QuarkOS force-pushed the chore/fix-typos-logs branch from d5d126e to 914023e Compare November 27, 2025 17:06
@quarkus-bot
Copy link

quarkus-bot bot commented Nov 27, 2025

Status for workflow Quarkus Documentation CI

This is the status report for running Quarkus Documentation CI on commit 914023e.

✅ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

Warning

There are other workflow runs running, you probably need to wait for their status before merging.

@github-actions
Copy link

🎊 PR Preview 3f428b9 has been successfully built and deployed to https://quarkus-pr-main-51260-preview.surge.sh/version/main/guides/

  • Images of blog posts older than 3 months are not available.
  • Newsletters older than 3 months are not available.

@quarkus-bot
Copy link

quarkus-bot bot commented Nov 27, 2025

Status for workflow Quarkus CI

This is the status report for running Quarkus CI on commit 914023e.

✅ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

You can consult the Develocity build scans.


Flaky tests - Develocity

⚙️ JVM Tests - JDK 25

📦 extensions/smallrye-graphql/deployment

io.quarkus.smallrye.graphql.deployment.CompletionStageTest.testSourcePost - History

  • 1 expectation failed. Expected status code <200> but was <500>. - java.lang.AssertionError
java.lang.AssertionError: 
1 expectation failed.
Expected status code <200> but was <500>.

	at java.base/jdk.internal.reflect.DirectConstructorHandleAccessor.newInstance(DirectConstructorHandleAccessor.java:62)
	at java.base/java.lang.reflect.Constructor.newInstanceWithCaller(Constructor.java:499)
	at java.base/java.lang.reflect.Constructor.newInstance(Constructor.java:483)
	at org.codehaus.groovy.reflection.CachedConstructor.invoke(CachedConstructor.java:73)

⚙️ MicroProfile TCKs Tests

📦 tcks/microprofile-lra

org.eclipse.microprofile.lra.tck.TckRecoveryTests.testCancelWhenParticipantIsUnavailable - History

  • Expecting the metric Compensated callback was called Expected: a value equal to or greater than <1> but: <0> was less than <1> - java.lang.AssertionError
java.lang.AssertionError: 
Expecting the metric Compensated callback was called
Expected: a value equal to or greater than <1>
     but: <0> was less than <1>
	at org.hamcrest.MatcherAssert.assertThat(MatcherAssert.java:20)
	at org.eclipse.microprofile.lra.tck.TckRecoveryTests.assertMetricCallbackCalled(TckRecoveryTests.java:210)
	at org.eclipse.microprofile.lra.tck.TckRecoveryTests.testCancelWhenParticipantIsUnavailable(TckRecoveryTests.java:195)
	at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/core area/devtools Issues/PR related to maven, gradle, platform and cli tooling/plugins area/graphql area/kubernetes area/oidc area/openapi area/platform Issues related to definition and interaction with Quarkus Platform area/qute The template engine area/redis area/smallrye area/testing triage/flaky-test

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants