-
Notifications
You must be signed in to change notification settings - Fork 3k
Fix typos across multiple modules and rename ReponseInfoTest #51260
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
gsmet
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks. The typo fixes looks good but I think we should revert the changes in StartupLogCompressor and squash.
Can you take care of it?
| if (sl != null) { | ||
| sl.close(); | ||
| } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think this is needed as it's protected by the thread == null test.
Same for the other fixes in this class.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done. Ive reverted the changes to StartupLogCompressor.java and squashed the commits
Corrected spelling errors in Javadocs, logs, and comments across OIDC, Kubernetes, and Qute extensions. Renamed ReponseInfoTest to ResponseInfoTest to fix class name typo. Signed-off-by: Quark <[email protected]>
d5d126e to
914023e
Compare
Status for workflow
|
|
🎊 PR Preview 3f428b9 has been successfully built and deployed to https://quarkus-pr-main-51260-preview.surge.sh/version/main/guides/
|
Status for workflow
|

Summary
While reviewing the codebase, I identified and corrected spelling errors across several extensions (Kubernetes, Redis, Qute, OIDC) and independent projects
Changes
ReponseInfoTesttoResponseInfoTestinindependent-projects/resteasy-reactiveto fix a typo in the class nameOidcClientRegistrationImplandRegisteredClientImplto improve log searchabilityImageBuilder,WebSocket, etcVerification
git statusshowedrenamed:)Checklist