Restructuring minireq for flexibility #20
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes the storage of actual function pointers from
minireq. The generated API was too restrictive in that every handler had to have the same signature. It also made it impossible to use two lockable RTIC resources as the context.With this approach, the user is responsible for routing to the appropriate handler, but they can make the signature of the handler whatever they would like.
This is in support of quartiq/booster#406, where one of the command handlers needs both the flash interface of Booster as well as the I2C bus interface, which are both separate, lockable RTIC resources.