Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: make description consistent with link-external-filter example code #1332

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

mcanouil
Copy link
Contributor

@mcanouil mcanouil commented Sep 15, 2024

The pull request fixes an inconsistency in the example description, making it consistent with the example code.

Fixes quarto-dev/quarto-cli#10780

@soxofaan
Copy link

also note that this example is repeated at

"name": "link-external-filter",
"description": "A regular expression that can be used to determine whether a link is an internal link. For example, \nthe following will treat links that start with http://www.quarto.org as internal links (and others\nwill be considered external):\n\n```\n^(?:http:|https:)\\/\\/www\\.quarto\\.org\\/custom\n```\n"
which also has to be addressed I think

@mcanouil mcanouil changed the title fix: make example description consistent with example code fix: make description consistent with link-external-filter example code Sep 16, 2024
@cderv cderv requested a review from cscheid September 16, 2024 14:16
@cscheid
Copy link
Collaborator

cscheid commented Sep 16, 2024

which also has to be addressed I think

For everyone's sake, quarto-web/docs/reference/formats/html.json is autogenerated by tools/reference.ts, which is updated by quarto run tools/reference.ts, as described on our README.

So the workflow here is we first fix the schema files (that's quarto-dev/quarto-cli#10806), then we run the command above, and do a separate PR here with the results here.

@mcanouil
Copy link
Contributor Author

Indeed for the reference pages.
Also why this PR only changes the hardcoded example.

@mcanouil
Copy link
Contributor Author

mcanouil commented Mar 8, 2025

FWIW, the PR I mentioned for the reference pages:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Confusing link-external-filter example
3 participants