-
Notifications
You must be signed in to change notification settings - Fork 898
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: dark brand #1614
base: prerelease
Are you sure you want to change the base?
docs: dark brand #1614
Conversation
🚀 Deployed on https://deploy-preview-1614.quarto.org |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This all looks great. A few places that could use a bit more clarification.
I'll open a PR for the updates to the reference so you can take a look.
docs/output-formats/html-themes.qmd
Outdated
@@ -101,10 +101,12 @@ Setting the above themes in your `_quarto.yml` results in both a dark and light | |||
|
|||
When providing both a dark and light mode for your html output, Quarto will automatically create a toggle to allow your reader to select the desired dark or light appearance. The toggle will automatically appear in the top right corner of your html output. When possible, the toggle will use browser local storage to maintain the user's preference across sessions. | |||
|
|||
The first appearance (light or dark) elements in the theme to determine the default appearance for your html output. For example, since the `light` option appears first in the above example, a reader will see the light appearance by default. | |||
To honor the user's operating system or browser preference for light or dark mode, specify `respect-user-color-scheme: true`. Otherwise, the order of light and dark elements in the theme or brand will determine the default appearance for your html output. For example, since the `light` option appears first in the above example, a reader will see the light appearance by default, if `respect-user-color-scheme` is not enabled. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Specify where? Is this a YAML option under theme
? I'd probably put an example right after the first sentence.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good idea. It's a new HTML document option. Will do.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Adding the example meant invalidating the reference to "above example" in the next sentence, so I changed it to "first example". Is this clear?
🚀 Deployed on https://deploy-preview-1614.quarto.org |
🚀 Deployed on https://deploy-preview-1614.quarto.org |
I've added documentation for Typst I also added minimal documentation for @cwickham, please give this another read for clarity. |
🚀 Deployed on https://deploy-preview-1614.quarto.org |
🚀 Deployed on https://deploy-preview-1614.quarto.org |
🚀 Deployed on https://deploy-preview-1614.quarto.org |
🚀 Deployed on https://deploy-preview-1614.quarto.org |
Co-authored-by: Charlotte Wickham <[email protected]>
update ref remove language about it not being dynamic, due to quarto-dev/quarto-cli#12465
remove limitation fixed by quarto-dev/quarto-cli#11811
add link to advanced typst brand yaml doc fixes quarto-dev/quarto-cli#12181
🚀 Deployed on https://deploy-preview-1614.quarto.org |
9f299a2
to
05a53f2
Compare
I've also moved the document logo customization documentation out of the advanced Typst brand yml docs and into the main Brand page. This fixes quarto-dev/quarto-cli#12181. I don't know if this belongs here, but it should be somewhere on the main site. The remaining helpful info on the Advanced page has to do with typography, so I've added a link there. I realized I had put the I think this completes my documentation tasks for 1.7 (aside from needing to return to Glad to edit or expand any of this. |
🚀 Deployed on https://deploy-preview-1614.quarto.org |
🚀 Deployed on https://deploy-preview-1614.quarto.org |
🚀 Deployed on https://deploy-preview-1614.quarto.org |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! A few minor suggestions.
In terms of renderings
:
- We definitely need some examples. Can we do screenshots for now? Not sure how big a job it is to implement dark mode on quarto.org.
- Where were you thinking of putting the examples? Maybe
docs/computations/execution-options.html#figure-options
? - I think you might have mentioned you can construct light/dark variations of (e.g.) screenshots by constructing divs with the right classes. Is this something we want to document?
It's starting to feel like the dark mode details are spread all over the place and we might want a single page that describes implenting dark mode on a website: setting themes, brand and renderings.
Co-authored-by: Charlotte Wickham <[email protected]>
🚀 Deployed on https://deploy-preview-1614.quarto.org |
Light/dark renderings exampleA problem with adding an example today is that we don't have the helper libraries... I'm trying to put the release and docs to bed so that I can get back to the user side. (This might include syntactic sugar to avoid duplicate code, like the custom print function you came up with.) So a minimal ggplot example is about 56 lines, but 34 lines of this (the first code cell) is the stuff that is supposed to in the helper library:
I think it would be okay at 12 lines, and I agree it fits in Non-computational light and darkWe can add this but I'm not sure where it goes. It's not really brand or theme but just the way our CSS works. A minimal example without any resources would be
This example is self-explanatory but kind of useless. Would it be better with images? EDIT: that example only works for HTML; the cross-format way to do this is currently to imitate cell output. Too ugly to document?
|
we no longer need to document Typst 0.11 behavior, since we ship with 0.13 now
🚀 Deployed on https://deploy-preview-1614.quarto.org |
I think we should merge this and then continue with examples for Unless you want to reorganize to a single dark mode page? I have an example at 22 lines, using your But we need to contribute the 40 lines of
|
Hi @cwickham, here is the first of my doc PRs for Quarto 1.7, covering Dark Brand.
I'll follow up with more commits covering the changes for Typst, and a separate PR for
renderings
.(I will also need to check that my schema changes have made it into the reference documentation, hmm.)
Please let me know what you think - glad to edit, move content, etc.
Thanks!