Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check for new Quarto version for R pkg support #455

Merged
merged 1 commit into from
May 30, 2024

Conversation

juliasilge
Copy link
Collaborator

@juliasilge juliasilge commented May 30, 2024

Related to #435

As folks have started using this, we realized we need to make sure they have the right version of Quarto itself! This adds the same kind of window.showWarningMessage() as is used here.

I chose the Quarto version that also has the fix for .quarto directories. Warning if you have an older Quarto looks like this:

warning-version-window

The early return keeps the document from rendering but it will still have opened a new terminal. I tend to think that's OK.

There's a couple of whitespace changes in this file from the new formatting added in b47a56d.

@juliasilge juliasilge marked this pull request as ready for review May 30, 2024 18:15
@juliasilge juliasilge requested a review from cscheid May 30, 2024 18:17
@jjallaire jjallaire merged commit 06678d5 into main May 30, 2024
1 check passed
@juliasilge juliasilge deleted the bump-version-for-r-pkgs branch May 30, 2024 19:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants