Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

suppress background highlight on first line #537

Merged

Conversation

kevinushey
Copy link
Contributor

Some Ace highlight rules will also give tokens a background highlight color. For example, Stan's highlight rules (in RStudio) give var a red background highlight. Unfortunately, these highlight rules also apply to tokens on the first line, and so we can end up with a chunk like so:

Screenshot 2024-09-11 at 3 09 37 PM

This PR alleviates that by forcing background: none !important in the CSS for panmirror.

@cscheid
Copy link
Contributor

cscheid commented Sep 11, 2024

Is there any reason we'd ever want the first line to be highlighted?

@jjallaire jjallaire merged commit 9a198c4 into quarto-dev:main Sep 16, 2024
1 check passed
@kevinushey
Copy link
Contributor Author

Is there any reason we'd ever want the first line to be highlighted?

I don't think so, but it's plausible that we'll want to some day adjust the treatment of the chunk header in the future? That seems like an overall larger project though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants