Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf(lexer): improve lexer performance by optimizing token matching #1008

Merged
merged 1 commit into from
Dec 2, 2024

Conversation

gvozdvmozgu
Copy link
Collaborator

No description provided.

This comment was marked as outdated.

This comment was marked as outdated.

@gvozdvmozgu gvozdvmozgu marked this pull request as draft December 1, 2024 13:32

This comment was marked as outdated.

This comment was marked as outdated.

@gvozdvmozgu gvozdvmozgu force-pushed the optimize-lexer-performance branch 2 times, most recently from 8cd62c4 to 3ebaeea Compare December 2, 2024 06:11

This comment was marked as outdated.

This comment was marked as outdated.

@gvozdvmozgu gvozdvmozgu force-pushed the optimize-lexer-performance branch from 3ebaeea to 764e655 Compare December 2, 2024 07:17
@gvozdvmozgu gvozdvmozgu force-pushed the optimize-lexer-performance branch from 764e655 to 4b4672f Compare December 2, 2024 07:30
@gvozdvmozgu gvozdvmozgu marked this pull request as ready for review December 2, 2024 07:35
Copy link

github-actions bot commented Dec 2, 2024

Benchmark for e052f32

Click to view benchmark
Test Base PR %
DepthMap::from_parent 42.1±0.45µs 40.2±0.33µs -4.51%
fix_complex_query 10.4±0.14ms 10.2±0.09ms -1.92%
parse_complex_query 2.9±0.03µs 2.9±0.03µs 0.00%
parse_expression_recursion 5.2±0.15µs 5.1±0.05µs -1.92%
parse_simple_query 818.0±12.34ns 797.4±14.19ns -2.52%

@gvozdvmozgu gvozdvmozgu requested a review from benfdking December 2, 2024 07:40
Copy link

github-actions bot commented Dec 2, 2024

Benchmark for b4e38c2

Click to view benchmark
Test Base PR %
DepthMap::from_parent 41.5±0.75µs 40.2±0.45µs -3.13%
fix_complex_query 10.3±0.09ms 10.4±0.12ms +0.97%
parse_complex_query 2.9±0.04µs 2.9±0.04µs 0.00%
parse_expression_recursion 5.1±0.05µs 5.1±0.06µs 0.00%
parse_simple_query 807.5±6.29ns 794.8±6.68ns -1.57%

@benfdking benfdking added this pull request to the merge queue Dec 2, 2024
Merged via the queue into main with commit d543b52 Dec 2, 2024
36 checks passed
@benfdking benfdking deleted the optimize-lexer-performance branch December 2, 2024 11:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants