Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: github returs errors alway in different order and repeats #1009

Closed
wants to merge 2 commits into from

Conversation

benfdking
Copy link
Collaborator

  • fix: github actions detection not working properly
  • chore: added tests and centralised strum deps
  • temp

Copy link

github-actions bot commented Dec 1, 2024

Benchmark for 1a2307b

Click to view benchmark
Test Base PR %
DepthMap::from_parent 41.9±0.38µs 41.6±0.39µs -0.72%
fix_complex_query 10.2±0.06ms 10.2±0.08ms 0.00%
parse_complex_query 2.9±0.03µs 2.9±0.04µs 0.00%
parse_expression_recursion 5.1±0.05µs 5.1±0.07µs 0.00%
parse_simple_query 819.1±11.59ns 857.7±33.91ns +4.71%

@benfdking benfdking force-pushed the fix-gthub-returns-in-different-order branch from 2592ff9 to 37df0e6 Compare December 2, 2024 17:59
Copy link

github-actions bot commented Dec 2, 2024

Benchmark for 620b6c1

Click to view benchmark
Test Base PR %
DepthMap::from_parent 41.1±0.35µs 41.5±0.37µs +0.97%
fix_complex_query 10.3±0.21ms 10.3±0.09ms 0.00%
parse_complex_query 2.9±0.07µs 2.8±0.04µs -3.45%
parse_expression_recursion 5.0±0.04µs 5.0±0.03µs 0.00%
parse_simple_query 814.5±13.13ns 805.8±20.55ns -1.07%

@benfdking benfdking closed this Dec 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant