Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: move formatter to depend on interface #1032

Merged
merged 1 commit into from
Dec 4, 2024

Conversation

benfdking
Copy link
Collaborator

@benfdking benfdking commented Dec 4, 2024

No description provided.

@benfdking benfdking force-pushed the working_on_github_formatter branch from d44ffec to 7686c49 Compare December 4, 2024 10:37
@benfdking benfdking changed the title working on github formatter chore: move formatter to depend on interface Dec 4, 2024
Copy link

github-actions bot commented Dec 4, 2024

Benchmark for a2f14da

Click to view benchmark
Test Base PR %
DepthMap::from_parent 40.5±0.85µs 41.2±1.40µs +1.73%
fix_complex_query 10.2±0.24ms 10.3±0.10ms +0.98%
parse_complex_query 2.8±0.03µs 2.8±0.03µs 0.00%
parse_expression_recursion 5.0±0.04µs 5.0±0.04µs 0.00%
parse_simple_query 812.9±22.01ns 830.1±18.54ns +2.12%

@benfdking benfdking force-pushed the working_on_github_formatter branch from 7686c49 to 30d0ee9 Compare December 4, 2024 11:11
Copy link

github-actions bot commented Dec 4, 2024

Benchmark for 7d06caa

Click to view benchmark
Test Base PR %
DepthMap::from_parent 40.5±0.32µs 41.3±1.16µs +1.98%
fix_complex_query 10.4±0.06ms 10.4±0.17ms 0.00%
parse_complex_query 2.8±0.02µs 2.8±0.03µs 0.00%
parse_expression_recursion 5.0±0.04µs 5.1±0.06µs +2.00%
parse_simple_query 818.6±9.66ns 832.2±8.06ns +1.66%

@benfdking benfdking merged commit a69ad87 into main Dec 4, 2024
35 of 36 checks passed
@benfdking benfdking deleted the working_on_github_formatter branch December 4, 2024 11:29
tmeijn pushed a commit to tmeijn/dotfiles that referenced this pull request Dec 10, 2024
This MR contains the following updates:

| Package | Update | Change |
|---|---|---|
| [quarylabs/sqruff](https://github.com/quarylabs/sqruff) | patch | `v0.21.8` -> `v0.21.9` |

MR created with the help of [el-capitano/tools/renovate-bot](https://gitlab.com/el-capitano/tools/renovate-bot).

**Proposed changes to behavior should be submitted there as MRs.**

---

### Release Notes

<details>
<summary>quarylabs/sqruff (quarylabs/sqruff)</summary>

### [`v0.21.9`](https://github.com/quarylabs/sqruff/releases/tag/v0.21.9)

[Compare Source](quarylabs/sqruff@v0.21.8...v0.21.9)

#### What's Changed

-   chore: remove unnecessary methods by [@&#8203;benfdking](https://github.com/benfdking) in quarylabs/sqruff#1031
-   chore: move formatter to depend on interface by [@&#8203;benfdking](https://github.com/benfdking) in quarylabs/sqruff#1032
-   refactor: make github native a fomatter by [@&#8203;benfdking](https://github.com/benfdking) in quarylabs/sqruff#1033
-   chore: update maturin and gha associated job by [@&#8203;benfdking](https://github.com/benfdking) in quarylabs/sqruff#1035
-   chore: bump version by [@&#8203;benfdking](https://github.com/benfdking) in quarylabs/sqruff#1037

**Full Changelog**: quarylabs/sqruff@v0.21.8...v0.21.9

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied.

♻ **Rebasing**: Whenever MR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 **Ignore**: Close this MR and you won't be reminded about this update again.

---

 - [ ] <!-- rebase-check -->If you want to rebase/retry this MR, check this box

---

This MR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate).
<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy40NDAuNyIsInVwZGF0ZWRJblZlciI6IjM3LjQ0MC43IiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6WyJSZW5vdmF0ZSBCb3QiXX0=-->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant