Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: make github native a fomatter #1033

Merged
merged 1 commit into from
Dec 5, 2024

Conversation

benfdking
Copy link
Collaborator

No description provided.

Copy link

github-actions bot commented Dec 4, 2024

Benchmark for 465b7fb

Click to view benchmark
Test Base PR %
DepthMap::from_parent 40.3±0.27µs 41.1±0.67µs +1.99%
fix_complex_query 10.3±0.26ms 10.4±0.12ms +0.97%
parse_complex_query 2.8±0.03µs 2.8±0.04µs 0.00%
parse_expression_recursion 5.1±0.07µs 5.0±0.04µs -1.96%
parse_simple_query 804.9±10.74ns 797.7±25.20ns -0.89%

@benfdking benfdking force-pushed the benfdking/impleminting_github_native_formatter branch from 02e9772 to c42a820 Compare December 5, 2024 10:31
Copy link

github-actions bot commented Dec 5, 2024

Benchmark for 1cba99b

Click to view benchmark
Test Base PR %
DepthMap::from_parent 41.0±0.63µs 41.0±0.58µs 0.00%
fix_complex_query 10.4±0.26ms 10.6±0.41ms +1.92%
parse_complex_query 2.9±0.03µs 2.9±0.06µs 0.00%
parse_expression_recursion 5.0±0.09µs 5.0±0.06µs 0.00%
parse_simple_query 808.8±10.40ns 806.3±19.74ns -0.31%

@benfdking benfdking force-pushed the benfdking/impleminting_github_native_formatter branch from c42a820 to ab4ae92 Compare December 5, 2024 10:54
Copy link

github-actions bot commented Dec 5, 2024

Benchmark for 57782b4

Click to view benchmark
Test Base PR %
DepthMap::from_parent 40.7±0.22µs 40.7±0.65µs 0.00%
fix_complex_query 10.4±0.20ms 10.2±0.07ms -1.92%
parse_complex_query 2.8±0.02µs 2.8±0.02µs 0.00%
parse_expression_recursion 5.0±0.06µs 5.3±0.06µs +6.00%
parse_simple_query 812.9±23.90ns 805.8±10.81ns -0.87%

@benfdking benfdking force-pushed the benfdking/impleminting_github_native_formatter branch from ab4ae92 to 6027b43 Compare December 5, 2024 11:28
Copy link

github-actions bot commented Dec 5, 2024

Benchmark for 2062f5a

Click to view benchmark
Test Base PR %
DepthMap::from_parent 41.0±1.10µs 40.9±0.22µs -0.24%
fix_complex_query 10.4±0.19ms 10.2±0.08ms -1.92%
parse_complex_query 2.8±0.03µs 2.8±0.03µs 0.00%
parse_expression_recursion 5.2±0.07µs 5.0±0.11µs -3.85%
parse_simple_query 822.6±29.46ns 810.4±27.25ns -1.48%

@benfdking benfdking force-pushed the benfdking/impleminting_github_native_formatter branch from 6027b43 to da7fc24 Compare December 5, 2024 14:23
Copy link

github-actions bot commented Dec 5, 2024

Benchmark for 0200ed2

Click to view benchmark
Test Base PR %
DepthMap::from_parent 40.7±0.28µs 40.9±0.86µs +0.49%
fix_complex_query 10.4±0.10ms 10.4±0.27ms 0.00%
parse_complex_query 2.8±0.04µs 2.8±0.02µs 0.00%
parse_expression_recursion 5.0±0.05µs 5.0±0.04µs 0.00%
parse_simple_query 808.3±24.63ns 806.9±20.02ns -0.17%

@benfdking benfdking force-pushed the benfdking/impleminting_github_native_formatter branch from da7fc24 to fc5b5f1 Compare December 5, 2024 15:35
@benfdking benfdking merged commit c77fee5 into main Dec 5, 2024
34 of 35 checks passed
@benfdking benfdking deleted the benfdking/impleminting_github_native_formatter branch December 5, 2024 15:46
Copy link

github-actions bot commented Dec 5, 2024

Benchmark for 2a8d3da

Click to view benchmark
Test Base PR %
DepthMap::from_parent 40.7±0.27µs 41.5±0.37µs +1.97%
fix_complex_query 10.5±0.29ms 10.6±0.18ms +0.95%
parse_complex_query 2.9±0.19µs 2.8±0.04µs -3.45%
parse_expression_recursion 5.0±0.08µs 5.1±0.02µs +2.00%
parse_simple_query 825.9±11.00ns 824.7±21.89ns -0.15%

tmeijn pushed a commit to tmeijn/dotfiles that referenced this pull request Dec 10, 2024
This MR contains the following updates:

| Package | Update | Change |
|---|---|---|
| [quarylabs/sqruff](https://github.com/quarylabs/sqruff) | patch | `v0.21.8` -> `v0.21.9` |

MR created with the help of [el-capitano/tools/renovate-bot](https://gitlab.com/el-capitano/tools/renovate-bot).

**Proposed changes to behavior should be submitted there as MRs.**

---

### Release Notes

<details>
<summary>quarylabs/sqruff (quarylabs/sqruff)</summary>

### [`v0.21.9`](https://github.com/quarylabs/sqruff/releases/tag/v0.21.9)

[Compare Source](quarylabs/sqruff@v0.21.8...v0.21.9)

#### What's Changed

-   chore: remove unnecessary methods by [@&#8203;benfdking](https://github.com/benfdking) in quarylabs/sqruff#1031
-   chore: move formatter to depend on interface by [@&#8203;benfdking](https://github.com/benfdking) in quarylabs/sqruff#1032
-   refactor: make github native a fomatter by [@&#8203;benfdking](https://github.com/benfdking) in quarylabs/sqruff#1033
-   chore: update maturin and gha associated job by [@&#8203;benfdking](https://github.com/benfdking) in quarylabs/sqruff#1035
-   chore: bump version by [@&#8203;benfdking](https://github.com/benfdking) in quarylabs/sqruff#1037

**Full Changelog**: quarylabs/sqruff@v0.21.8...v0.21.9

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied.

♻ **Rebasing**: Whenever MR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 **Ignore**: Close this MR and you won't be reminded about this update again.

---

 - [ ] <!-- rebase-check -->If you want to rebase/retry this MR, check this box

---

This MR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate).
<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy40NDAuNyIsInVwZGF0ZWRJblZlciI6IjM3LjQ0MC43IiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6WyJSZW5vdmF0ZSBCb3QiXX0=-->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant