Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: on fix command non-fixable violations force return of 1 #1057

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

fix: on fix command non-fixable violations force return of 1 #1057

wants to merge 2 commits into from
+14 −18

Conversation

benfdking
Copy link
Collaborator

No description provided.

@benfdking benfdking linked an issue Dec 15, 2024 that may be closed by this pull request
Optionaly give a return code of 1 for sqruff fix if anything is flagged #893
Open
@benfdking benfdking marked this pull request as draft December 15, 2024 20:13
@github-actions GitHub Actions
Copy link

Benchmark for 89571fd

Click to view benchmark
Test Base PR %
DepthMap::from_parent 41.1±0.39µs 41.9±1.24µs +1.95%
fix_complex_query 10.3±0.17ms 10.2±0.15ms -0.97%
parse_complex_query 2.9±0.02µs 2.9±0.02µs 0.00%
parse_expression_recursion 5.0±0.08µs 5.0±0.04µs 0.00%
parse_simple_query 802.5±10.63ns 813.2±50.66ns +1.33%

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Optionaly give a return code of 1 for sqruff fix if anything is flagged
1 participant
@benfdking