feat: add sqruff as a VSCode extension #369
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Benchmark for 8b0ce87Click to view benchmark
|
Benchmark for a07c3efClick to view benchmark
|
12 tasks
gvozdvmozgu
force-pushed
the
vscode
branch
2 times, most recently
from
9276efa to
631b9e6
Compare
Benchmark for fbe7902Click to view benchmark
|
Benchmark for b1ae0cdClick to view benchmark
|
Benchmark for cc1d967Click to view benchmark
|
…refactor diagnostic checking
Benchmark for b8cbdd2Click to view benchmark
|
Benchmark for c89602fClick to view benchmark
|
Benchmark for 6e0da46Click to view benchmark
|
Benchmark for da250beClick to view benchmark
|
Benchmark for 14206c7Click to view benchmark
|
benfdking
reviewed
Jun 16, 2024
There was a problem hiding this comment.
Hey @gvozdvmozgu,
Great work, I am just wondering, I am struggling to get it to work in browser, what are the steps that you have run to test/run it?
Comment on lines
+4
to
+19
| export function activate(context: vscode.ExtensionContext) { | ||
| const serverMain = vscode.Uri.joinPath( | ||
| context.extensionUri, | ||
| "dist/browserServerMain.js", | ||
| ); | ||
|
|
||
| const worker = new Worker(serverMain.toString(true)); | ||
| worker.onmessage = (message) => { | ||
| if (message.data !== "OK") { | ||
| return; | ||
| } | ||
|
|
||
| const cl = new LanguageClient("sqruff-lsp", "Sqruff LSP", { documentSelector: [{ language: "sql" }] }, worker); | ||
| cl.start().then(() => { }); | ||
| }; | ||
| } |
There was a problem hiding this comment.
I am struggling to see how you are testing this in the browser. Did you run npm run run-in-browser? and what before?
There was a problem hiding this comment.
npm run build:wasm_lsp && npm run compile && npm run run-in-browser
| @@ -0,0 +1,17 @@ | |||
| { | |||
| "compilerOptions": { | |||
| "module": "Node16", | |||
There was a problem hiding this comment.
nit: This here feels slightly odd version but not important.
Comment on lines
+14
to
+15
| with: | ||
| push_options: '--force' |
There was a problem hiding this comment.
nit: we should add some CI checks for this as well.
Benchmark for 36de1b5Click to view benchmark
|
Benchmark for bde5b91Click to view benchmark
|
|
I think there are a few things we should improve, but in the meantime, we should merge this:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.