New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: move segment types #734

Merged

benfdking merged 1 commit into main from refactor_segement_types

Sep 13, 2024

Collaborator

benfdking commented Sep 12, 2024

No description provided.


          refactor: move segment types

90c73b3

benfdking force-pushed the refactor_segement_types branch from ad1fe2f to 90c73b3 Compare

September 12, 2024 22:48

benfdking requested a review from gvozdvmozgu

September 12, 2024 22:48

github-actions bot commented Sep 12, 2024

Benchmark for `a651c37`

Click to view benchmark

Test	Base	PR	%
DepthMap::from_parent	41.2±0.42µs	40.8±0.53µs	-0.97%
fix_complex_query	11.2±0.18ms	11.2±0.19ms	0.00%
parse_complex_query	2.8±0.03µs	2.8±0.04µs	0.00%
parse_expression_recursion	5.2±0.05µs	4.9±0.03µs	-5.77%
parse_simple_query	820.4±17.23ns	823.1±39.59ns	+0.33%

github-actions bot commented Sep 12, 2024

Benchmark for `bbb46d9`

Click to view benchmark

Test	Base	PR	%
DepthMap::from_parent	41.2±0.31µs	40.8±0.23µs	-0.97%
fix_complex_query	11.4±0.30ms	11.3±0.17ms	-0.88%
parse_complex_query	2.8±0.03µs	2.8±0.03µs	0.00%
parse_expression_recursion	5.0±0.09µs	5.1±0.05µs	+2.00%
parse_simple_query	816.7±5.50ns	865.8±122.56ns	+6.01%

gvozdvmozgu approved these changes

View reviewed changes

benfdking added this pull request to the merge queue

Merged via the queue into main with commit a8f3cf2

13 checks passed

benfdking deleted the refactor_segement_types branch

September 13, 2024 08:14

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet