New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

internal: add features for all the dialects #778

Merged

benfdking merged 1 commit into main from add-features-for-all-the-dialects

Sep 17, 2024

Collaborator

gvozdvmozgu commented Sep 17, 2024

No description provided.

gvozdvmozgu force-pushed the add-features-for-all-the-dialects branch from 3fb370d to 7bc6e96 Compare

September 17, 2024 19:04

github-actions bot commented Sep 17, 2024

Benchmark for `de0ef46`

Click to view benchmark

Test	Base	PR	%
DepthMap::from_parent	40.8±0.41µs	42.8±1.41µs	+4.90%
fix_complex_query	11.6±0.24ms	11.3±0.11ms	-2.59%
parse_complex_query	2.8±0.04µs	2.9±0.04µs	+3.57%
parse_expression_recursion	5.0±0.06µs	5.2±0.05µs	+4.00%
parse_simple_query	803.1±40.69ns	848.1±84.31ns	+5.60%

github-actions bot commented Sep 17, 2024

Benchmark for `f406f67`

Click to view benchmark

Test	Base	PR	%
DepthMap::from_parent	40.9±0.64µs	41.8±0.52µs	+2.20%
fix_complex_query	11.5±0.09ms	11.5±0.28ms	0.00%
parse_complex_query	2.8±0.06µs	2.9±0.06µs	+3.57%
parse_expression_recursion	5.1±0.04µs	5.2±0.05µs	+1.96%
parse_simple_query	793.2±9.82ns	826.6±42.46ns	+4.21%

gvozdvmozgu requested a review from benfdking

September 17, 2024 19:23

benfdking approved these changes

View reviewed changes


          internal: add features for all the dialects

fb40594

benfdking force-pushed the add-features-for-all-the-dialects branch from 7bc6e96 to fb40594 Compare

September 17, 2024 22:14

benfdking added this pull request to the merge queue

Merged via the queue into main with commit a8ec417

benfdking deleted the add-features-for-all-the-dialects branch

September 17, 2024 22:15

github-actions bot commented Sep 17, 2024

Benchmark for `a8ec417`

Click to view benchmark

Test	Base	PR	%
DepthMap::from_parent	42.7±0.36µs	42.5±1.07µs	-0.47%
fix_complex_query	11.2±0.07ms	11.2±0.10ms	0.00%
parse_complex_query	2.8±0.04µs	2.9±0.03µs	+3.57%
parse_expression_recursion	5.3±0.05µs	5.2±0.04µs	-1.89%
parse_simple_query	814.4±8.52ns	821.8±10.89ns	+0.91%

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet