Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: implementing jinja templater #972

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

benfdking
Copy link
Collaborator

No description provided.

Copy link

Benchmark for c337e2f

Click to view benchmark
Test Base PR %
DepthMap::from_parent 41.8±0.53µs 40.2±0.27µs -3.83%
fix_complex_query 11.7±0.12ms 11.6±0.10ms -0.85%
parse_complex_query 2.9±0.05µs 2.9±0.04µs 0.00%
parse_expression_recursion 5.1±0.04µs 5.1±0.04µs 0.00%
parse_simple_query 860.6±8.33ns 852.9±52.83ns -0.89%

@mmitya
Copy link

mmitya commented Nov 27, 2024

Hey! This is promising!

@benfdking
Copy link
Collaborator Author

Hey @mmitya yep! It's slightly fiddly but getting there

@benfdking benfdking force-pushed the working_on_jinja_templater branch from ddc8c92 to b267e81 Compare November 28, 2024 16:46
Copy link

Benchmark for 8fc01cf

Click to view benchmark
Test Base PR %
DepthMap::from_parent 41.5±0.44µs 40.5±0.31µs -2.41%
fix_complex_query 11.6±0.09ms 11.7±0.27ms +0.86%
parse_complex_query 3.0±0.02µs 2.9±0.04µs -3.33%
parse_expression_recursion 5.2±0.05µs 5.2±0.03µs 0.00%
parse_simple_query 843.6±14.02ns 840.8±26.42ns -0.33%

Copy link

Benchmark for 0299596

Click to view benchmark
Test Base PR %
DepthMap::from_parent 42.6±0.25µs 41.2±1.12µs -3.29%
fix_complex_query 11.7±0.10ms 11.7±0.11ms 0.00%
parse_complex_query 2.9±0.03µs 2.9±0.03µs 0.00%
parse_expression_recursion 5.2±0.09µs 5.3±0.06µs +1.92%
parse_simple_query 833.6±15.72ns 845.7±58.16ns +1.45%

@benfdking benfdking force-pushed the working_on_jinja_templater branch from 0918fe7 to b2c2d52 Compare November 28, 2024 17:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants