-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
machine-types/core refactoring to make it more flexible #140
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jouvin
force-pushed
the
machine_type_core_refactoring
branch
from
October 27, 2021 10:40
18b33f7
to
188ae58
Compare
jouvin
added a commit
to jouvin/template-library-grid
that referenced
this pull request
Oct 27, 2021
- Requires quattor/template-library-standard#140 - Support removed for WN profile cloning
jouvin
force-pushed
the
machine_type_core_refactoring
branch
3 times, most recently
from
October 27, 2021 17:59
d925bdd
to
4daa96e
Compare
jouvin
added a commit
to jouvin/template-library-grid
that referenced
this pull request
Oct 27, 2021
- Requires quattor/template-library-standard#140 - Support removed for WN profile cloning
jouvin
added a commit
to jouvin/template-library-grid
that referenced
this pull request
Oct 27, 2021
- Requires quattor/template-library-standard#140 - Support removed for WN profile cloning
jouvin
added a commit
to jouvin/template-library-grid
that referenced
this pull request
Oct 27, 2021
- Requires quattor/template-library-standard#140 - Support removed for WN profile cloning
jouvin
added a commit
to jouvin/template-library-grid
that referenced
this pull request
Oct 27, 2021
- Requires quattor/template-library-standard#140 - Support removed for WN profile cloning
Pansanel
reviewed
Jan 4, 2022
jouvin
force-pushed
the
machine_type_core_refactoring
branch
from
March 23, 2022 22:11
4daa96e
to
c3b091e
Compare
- Initial part factored out in a separate template, core-init.pan, to allow execution of site specific actions between this initial part and the core configuration - Ability to delay some part of the configuration, like file systems, in case some site information must be defined before - Hook to configure time synchronisation according to site needs (ntp, chrony...) - Template cleanup
jouvin
force-pushed
the
machine_type_core_refactoring
branch
from
March 23, 2022 22:12
c3b091e
to
c9b56a0
Compare
@Pansanel thanks for your detailed review and apologizes for the late follow-up... Hopefully I fixed everything. |
jouvin
added a commit
to jouvin/template-library-grid
that referenced
this pull request
Mar 31, 2022
- Requires quattor/template-library-standard#140 - Support removed for WN profile cloning - Lemon support removed - EL6 support removed
jrha
approved these changes
Dec 9, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
execution of site specific actions between this initial part and the core configuration
information must be defined before