feat(config): add shared ADS types and architecture doc#113
Merged
q-soriarty merged 1 commit intodevelopfrom Feb 14, 2026
Merged
feat(config): add shared ADS types and architecture doc#113q-soriarty merged 1 commit intodevelopfrom
q-soriarty merged 1 commit intodevelopfrom
Conversation
Add PlcAdsState enum, PlcStateDto, AdsConnectionInfo, and AdsVariableSubscription to FlowForge.Shared for use across monitor and build server without requiring Beckhoff NuGet dependencies. Update PlcTargetDto with CurrentState and DeployRequestDto with AdsPort. Create doc/ADS_INTEGRATION.md documenting the decision to use direct Beckhoff.TwinCAT.Ads instead of custom MQTT ADS relay topics. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This was referenced Feb 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
PlcAdsStateenum mirroring TwinCATAdsState(avoids Beckhoff NuGet dependency in Shared)PlcStateDto,AdsConnectionInfo,AdsVariableSubscriptionshared DTOsPlcTargetDtowithCurrentStateproperty andDeployRequestDtowithAdsPortdoc/ADS_INTEGRATION.mdarchitecture decision record with full research findingsContext
Foundation for replacing custom ADS-over-MQTT relay with direct Beckhoff.TwinCAT.Ads communication. See
doc/ADS_INTEGRATION.mdfor detailed rationale and API reference.Test plan
dotnet build src/shared/FlowForge.Shared/compiles without errorsdotnet build src/FlowForge.slncompiles without errors🤖 Generated with Claude Code