Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update PAN Decoder support encoder depth #999

Merged
merged 6 commits into from
Dec 9, 2024

Conversation

brianhou0208
Copy link
Contributor

Hi @qubvel,

This PR adds support for encoder_depth in the PAN decoder while ensuring compatibility with previously trained models, allowing them to be loaded without any issues.

Update

  1. Added type annotations for improved code clarity and robustness.
  2. Introduced support for encoder_depth with validation to handle various encoder configurations.
  3. Reduced the size of tests/test_models.py while maintaining test coverage.

Copy link
Collaborator

@qubvel qubvel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@brianhou0208 Thanks for the update!

segmentation_models_pytorch/decoders/pan/decoder.py Outdated Show resolved Hide resolved
@qubvel qubvel merged commit 480d303 into qubvel-org:main Dec 9, 2024
12 checks passed
@qubvel
Copy link
Collaborator

qubvel commented Dec 9, 2024

Thanks for your contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants