Skip to content

Conversation

depahelix2021
Copy link

If you do not provide both names, there should be a clear error message that says as much.

If a 500 Internal Server Error comes back, surface that to the user and hint that it is most likely because they are trying to create a rules collection for a Solr collection that already has one attached to it.

@epugh
Copy link
Contributor

epugh commented May 24, 2022

Error handling makes sense, however I wonder if there is also a better response code that the API could provide?

@depahelix2021
Copy link
Author

Now instead of a 500, the API catches that issue with SQL constraints not allowing the addition, and returns back a more normal BadRequest.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants