Remove test_conv.c (#800)

We only build it, we never run it, and it's fairly slow to build. It's an almost verbatim copy of a sizable part of cutils.c that _is_ tested so let's just remove it. Fixes: #788
quickjs-ng · Jan 7, 2025 · 291eb9c · 291eb9c
1 parent 4b8057d
commit 291eb9c
Show file tree

Hide file tree

Showing 3 changed files with 0 additions and 1,765 deletions.
diff --git a/CMakeLists.txt b/CMakeLists.txt
@@ -370,10 +370,6 @@ if(BUILD_EXAMPLES)
     target_link_libraries(test_fib qjs)
 endif()
 
-add_executable(test_conv
-    tests/test_conv.c
-)
-
 # Install target
 #
 

diff --git a/Makefile b/Makefile
@@ -58,9 +58,6 @@ $(QJS): $(BUILD_DIR)
 $(QJSC): $(BUILD_DIR)
 	cmake --build $(BUILD_DIR) --target qjsc -j $(JOBS)
 
-$(BUILD_DIR)/test_conv: $(BUILD_DIR) tests/test_conv.c
-	cmake --build $(BUILD_DIR) --target test_conv
-
 install: $(QJS) $(QJSC)
 	cmake --build $(BUILD_DIR) --target install
 
@@ -99,9 +96,6 @@ cxxtest: cxxtest.cc quickjs.h
 test: $(QJS)
 	$(RUN262) -c tests.conf
 
-testconv: $(BUILD_DIR)/test_conv
-	$(BUILD_DIR)/test_conv
-
 test262: $(QJS)
 	$(RUN262) -m -c test262.conf -a