Propagate exceptions in Iterator.concat #1256
Merged
+15
−46
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
test262 took a 180 degree turn because the test that is fixed by this commit is the polar opposite of what was tested by the test suite when I originally added Iterator.concat. The old behavior was not very efficient, so good for them for changing their minds, but next time please do so before I spend an hour implementing it, thank you very much.
saghul
approved these changes
Dec 1, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
test262 took a 180 degree turn because the test that is fixed by this commit is the polar opposite of what was tested by the test suite when I originally added Iterator.concat.
The old behavior was not very efficient, so good for them for changing their minds, but next time please do so before I spend an hour implementing it, thank you very much.