Add LTO support to CMake build #59
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm curious, does LTO make a difference in the quality of the generated code? It's effectively a single code unit already. Or is this for downstream consumers? Wouldn't they normally enforce that through CMAKE_C_FLAGS? |
|
TBH I haven't checked. Went for compatibility with the existing makefile. We could table this for if / when there are more units ;-) |
|
I strongly lean towards "do nothing until someone complains" :-) |
|
Oh, now that I think about it: LTO produced (and still produces) no end of build and runtime issues with node due to bugs in compilers and linkers, so... yeah. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.