Fix comment of JS_NewClassID #784
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
saghul
reviewed
Jan 4, 2025
| @@ -3519,7 +3519,7 @@ static inline BOOL JS_IsEmptyString(JSValue v) | |||
|
|
|||
| /* JSClass support */ | |||
|
|
|||
| /* a new class ID is allocated if *pclass_id != 0 */ | |||
| /* a new class ID is allocated if *pclass_id == 0, otherwise *pclass_id is left inchanged */ | |||
gschwind
force-pushed
the
pr-fix-js-newclassid-comment
branch
from
59b77d6 to
68e94ee
Compare
bnoordhuis
approved these changes
Jan 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The comment of the function JS_NewClassID is wrong. This patch fix it.
Best regards