Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix missing calls to va_end in libunicode #792

Merged
merged 1 commit into from
Jan 7, 2025
Merged

Conversation

ABBAPOH
Copy link
Contributor

@ABBAPOH ABBAPOH commented Jan 6, 2025

No description provided.

Copy link
Contributor

@saghul saghul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! How did you catch this?

@ABBAPOH
Copy link
Contributor Author

ABBAPOH commented Jan 6, 2025

Hello, we're using the old quickjs version in Qbs and we have several patches applied on top of it (mostly for Windows which you did also). Probably we encountered a crash at some point or ASAN was unhappy. Dunno really, we did those patches about 2 years ago so I don't really remember^^.
I started porting to the new engine, so I decided to bring those changes to the upstream.

@saghul saghul merged commit 84d11c4 into quickjs-ng:master Jan 7, 2025
59 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants